Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b7c9ac38-6f9b-8d05-39c6-fee9058209a9@linaro.org>
Date:   Tue, 11 Apr 2023 19:07:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous
 "input-enable"
Content-Language: en-US
To:     Johan Hovold <johan@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230407175807.124394-1-krzysztof.kozlowski@linaro.org>
 <20230407175807.124394-5-krzysztof.kozlowski@linaro.org>
 <ZDVq1b0TjXH5LTYx@hovoldconsulting.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <ZDVq1b0TjXH5LTYx@hovoldconsulting.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/04/2023 16:12, Johan Hovold wrote:
> On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote:
>> Pin configuration property "input-enable" was used with the intention to
>> disable the output, but this is done by default by Linux drivers.  Since
>> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
>> input-enable") the property is not accepted anymore.
> 
> This description does not seem to match the pin configurations that you
> are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl"
> binding for which 'input-enable' is still accepted AFAICT.
> 
> Perhaps you can fix up the lpass bindings (and driver?) to match?

Thanks for spotting this. This change is wrong.

Best regards,
Krzysztof