Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 13:14:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel@vger.kernel.org,
        "Jose E . Marchesi" <jose.marchesi@oracle.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Sami Tolvanen <samitolvanen@google.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3] tracepoint: Fix CFI failures with tp_sub_func
Message-ID: <20230411131423.37b001f7@gandalf.local.home>
In-Reply-To: <20230408230344.06f9c6c95d4659b2f5363ba0@kernel.org>
References: <20230324123142.7463-1-mathieu.desnoyers@efficios.com>
        <75dbeff6-fd0c-aec1-5821-919088eda6c4@efficios.com>
        <ZCwDAnRHjNr9ZftR@FVFF77S0Q05N>
        <20230404162232.1b2f4c2f@gandalf.local.home>
        <20230408230344.06f9c6c95d4659b2f5363ba0@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 8 Apr 2023 23:03:44 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> I think we need another stub function similar to the original patch, because
> the __tracestub_* functions are usually not called back. Even if I enabled
> the static key to enable the stub callback, if user sets another callback
> handler to the tracepoint (e.g. enable trace event on it), the __tracestub_*
> function is not called anymore.
> 
> Thus I think we just pick this version and add another patch to introduce
> __probestub_* functions in macro, and fprobe on it. This new stub function is
> something like the original one so that it doesn't break CFI. And it will be
> registered to tracepoint when the new fprobe based dynamic event is enabled.
> 

If we are going to add *another* stub, then no, I don't want to use it. But
I don't see why we can't use one stub for both?

What's the issue you are having?

-- Steve