Message-ID: <46F97BE1.4010508@oracle.com>
Date: Tue, 25 Sep 2007 14:21:37 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
User-Agent: Thunderbird 1.5.0.5 (X11/20060719)
MIME-Version: 1.0
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Sam Ravnborg <sam@ravnborg.org>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 3/5] Add samples subdir (updated)
References: <20070925121145.262664884@polymtl.ca> <20070925121251.954162366@polymtl.ca> <20070925190036.GA14579@uranus.ravnborg.org> <20070925133234.cdd9edf1.randy.dunlap@oracle.com> <20070925205021.GB16652@Krystal>
In-Reply-To: <20070925205021.GB16652@Krystal>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2545
Lines: 81

Mathieu Desnoyers wrote:
> Randy, since I did big changes to the patch, I removed your
> Signed-off-by. Tell me if you want me to add it back... (Is the From:
> still valid ?)
> 
> Mathieu

How about from: you and add
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> Add samples subdir (updated)
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Begin infrastructure for kernel code samples in the samples/ directory.
> Add its Kconfig and Kbuild files.
> 
> Changelog:
> - Move menu to Kernel Hacking
> - Don't build with the kernel image
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> ---
>  Makefile          |    3 +++
>  lib/Kconfig.debug |    2 ++
>  samples/Kconfig   |   11 +++++++++++
>  3 files changed, 16 insertions(+)
> 
> Index: linux-2.6-lttng/Makefile
> ===================================================================
> --- linux-2.6-lttng.orig/Makefile	2007-09-25 16:44:44.000000000 -0400
> +++ linux-2.6-lttng/Makefile	2007-09-25 16:45:13.000000000 -0400
> @@ -770,6 +770,9 @@ vmlinux: $(vmlinux-lds) $(vmlinux-init) 
>  ifdef CONFIG_HEADERS_CHECK
>  	$(Q)$(MAKE) -f $(srctree)/Makefile headers_check
>  endif
> +ifdef CONFIG_SAMPLES
> +	$(Q)$(MAKE) $(build)=samples
> +endif
>  	$(call vmlinux-modpost)
>  	$(call if_changed_rule,vmlinux__)
>  	$(Q)rm -f .old_version
> Index: linux-2.6-lttng/samples/Kconfig
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6-lttng/samples/Kconfig	2007-09-25 16:45:13.000000000 -0400
> @@ -0,0 +1,11 @@
> +# samples/Kconfig
> +
> +menuconfig SAMPLES
> +	bool "Sample kernel code"
> +	help
> +	  You can build and test sample kernel code here.
> +
> +if SAMPLES
> +
> +
> +endif # SAMPLES
> Index: linux-2.6-lttng/lib/Kconfig.debug
> ===================================================================
> --- linux-2.6-lttng.orig/lib/Kconfig.debug	2007-09-25 16:44:44.000000000 -0400
> +++ linux-2.6-lttng/lib/Kconfig.debug	2007-09-25 16:45:13.000000000 -0400
> @@ -558,3 +558,5 @@ config FAULT_INJECTION_STACKTRACE_FILTER
>  	  Provide stacktrace filter for fault-injection capabilities
>  
>  source "lib/Kconfig.kgdb"
> +
> +source "samples/Kconfig"
> 


-- 
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/