Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
In-Reply-To: <20230403065207.1070974-1-bjorn@kernel.org>
References: <20230403065207.1070974-1-bjorn@kernel.org>
Subject: Re: [PATCH] riscv: entry: Save a0 prior
 syscall_enter_from_user_mode()
Message-Id: <168123475135.4147.9051999374596978440.b4-ty@rivosinc.com>
Date:   Tue, 11 Apr 2023 10:39:11 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Cc:     =C3=B6rn_T=C3=B6pel?= <bjorn@rivosinc.com>,
        iko_St=C3=BCbner?= <heiko@sntech.de>,
        Conor Dooley <conor@kernel.org>,
        Yipeng Zou <zouyipeng@huawei.com>,
        linux-kernel@vger.kernel.org,
        Heiko Stuebner <heiko.stuebner@vrull.eu>
From:   Palmer Dabbelt <palmer@rivosinc.com>
To:     Albert Ou <aou@eecs.berkeley.edu>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv@lists.infradead.org, Guo Ren <guoren@kernel.org>,
        =C3=B6rn_T=C3=B6pel?= <bjorn@kernel.org>
Precedence: bulk


On Mon, 03 Apr 2023 08:52:07 +0200, Björn Töpel wrote:
> The RISC-V calling convention passes the first argument, and the
> return value in the a0 register. For this reason, the a0 register
> needs some extra care; When handling syscalls, the a0 register is
> saved into regs->orig_a0, so a0 can be properly restored for,
> e.g. interrupted syscalls.
> 
> This functionality was broken with the introduction of the generic
> entry patches. Here, a0 was saved into orig_a0 after calling
> syscall_enter_from_user_mode(), which can change regs->a0 for some
> paths, incorrectly restoring a0.
> 
> [...]

Applied, thanks!

[1/1] riscv: entry: Save a0 prior syscall_enter_from_user_mode()
      https://git.kernel.org/palmer/c/9c2598d43510

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>