Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 19:42:09 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvell.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com,
        corbet@lwn.net
Subject: Re: [net-next Patch v9 0/6] octeontx2-pf: HTB offload support
Message-ID: <ZDWb8QyRITjf4nKw@corigine.com>
References: <20230411090359.5134-1-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230411090359.5134-1-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+Oulj8ItP4CZcrtTK/IYOKQ72J63EZvhUV1GwTq1gsf7FbnfqhVQOYcC9DaG?=
 =?us-ascii?Q?xX0YcHu1/bEACJHz0m8N/8Hr3B/3Yp+kfXYSBElaNqCMD2a7X5tGHNjq6+YJ?=
 =?us-ascii?Q?TA4MDY9T/AYvihxzJO0YojLBJQucMOu/jg4eToO9L4BQFd5+gvfVEdpTg0YS?=
 =?us-ascii?Q?Mtw1Imy6flFMCk3U53HyQRrWioHTdNnwl7g9LlUhDO2xznScwiDUYYUKbGBR?=
 =?us-ascii?Q?Xqx78wvgeP+Mup0sXjQh1qyG3JSY4UZsXUSEs9PYQdMwLJ9gZT9WLEmk+sQ+?=
 =?us-ascii?Q?ErQB/cxz02KyRrjB+aper989JirNFCy5O6Vkajpoai35sJs+391iZnvoEJfl?=
 =?us-ascii?Q?3KvZQDb+Zs+PX4jGws0ctALaR26w4Wqh+96fAtAhbqaN0H0+H6lJ8ruSyysk?=
 =?us-ascii?Q?JUFOp+1+JEdoRiy8bySSBs89gVxvaGA6EVzvgpyGQb/QvKqFz5BZgEKMPRzc?=
 =?us-ascii?Q?uKDjrUlXskszec0vaZe9i3LEbzRfytfkLlhLEBqfG0JYo382TL3W6rr4afGd?=
 =?us-ascii?Q?LLNgD+9nRvh7lWYz1FcSKhjJoCLZMqUfJ0kp1DeVuDrBoWP4wfHnPdjZUcrd?=
 =?us-ascii?Q?YeIVW8zaDEt4Nav9J+/H0+b5ohjrVlE2hOxsn3bljnGqW8DWOTWBZWMN+cAJ?=
 =?us-ascii?Q?YYMHP994V1G442t4BCpgrT4MebTb68A2EaFt8Z1z2u5arsqWjOGJf/4Sf+QW?=
 =?us-ascii?Q?OfwgzOPpGND1G2ulqsy9bc+AzaKXC8+VVKWGsjsAlSZh3baGdWlpwCBY9FWr?=
 =?us-ascii?Q?KWjwD91cjYLvTEkBM5ZupoHQqfXT/LB/6UenJn3sP+JJFv7eKzDpO8cG59TF?=
 =?us-ascii?Q?voIjIFJzkkctJoqJxUQkkYsTLdN2qEEkZrQCImMyiRuHgEEUNvuyBG03CjMn?=
 =?us-ascii?Q?TXAzpNwKtwlKAIPROry5jZcMCscpb0UC7WdVy2lS5aiTQY3aFGmXsKo5NgLi?=
 =?us-ascii?Q?d4/pE5ocv8CG77GU7jqu/6+ZC+t4BcqMr6Zvfi09bLn5MrPiaQnl0xaFfBzO?=
 =?us-ascii?Q?h001YHpRr65jFgh++45AOgdcCcmAjdtRl1TPJNaMxWd0P2THILJEvmPCSRLA?=
 =?us-ascii?Q?9G2731j6KgHaIRqxyRRQXzxQofBMjXbI0OKiZeqb77uvDHcfRtVMJjk5qJ1t?=
 =?us-ascii?Q?jmpyVPXRe2X7xydS7zB6CZ6s4zSwHBtuiEYpYoYlztEQB1ppNyy90ioCXSjj?=
 =?us-ascii?Q?QpDe+zbTMqsvgdEqNwv1HdYcwccIEQyRW6wHrobVUOlp+kUm9U4+o6n1KgEh?=
 =?us-ascii?Q?s3RVBaOLDfgN0FxpoEj/Fon6WL2iHWZHPyoyCftpliImWhqTT2yoGEoM0/Nm?=
 =?us-ascii?Q?3XbdEmVYx4ikg2zYuL2phcZBhc9avqkk2PnbsIgbL95CNBqV9K//d8cOwPsg?=
 =?us-ascii?Q?G/onH1o0uRoOiVQ9RcCmmnBHQN2XQY8xtqop6N5O3G5sgRklkax0iXOj/qFM?=
 =?us-ascii?Q?RwV3w7S5e7VZI3ioHAnjEkHbUiqkW1Za9HkMxNngj7R0yiNj2VQfab4qk/Mi?=
 =?us-ascii?Q?WUnK4V/uV1ksPLRQtrh+04KiZJawf78lIQVyXqSN3CElo4VGYEsno9P8yq4U?=
 =?us-ascii?Q?Ob/3gA7WXGGsKVDZZIl1+SH2s/pzv7g4STVaNJpkdsVK6nlEp73jRPbnvpfM?=
 =?us-ascii?Q?ScXaldDsToEurQHIqgR5uwm4rXXVSXLihgPZe9xdKIUcjDbQF1cutDu6uS2D?=
 =?us-ascii?Q?FrN8yQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02dbdecc-a3e5-4762-b73e-08db3ab417b0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 17:42:17.1574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g+nRf0rVy13DozDxcQs3pz8qz62/Cd/NL0a9sFsLDpkJVGzvvCIJeOHKQPo+aVHTkV4QxJ2t44kJEWKrXjrF0RVVvU9YGoeydru4vfRVxf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR13MB6227
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 11, 2023 at 02:33:53PM +0530, Hariprasad Kelam wrote:
> octeontx2 silicon and CN10K transmit interface consists of five
> transmit levels starting from MDQ, TL4 to TL1. Once packets are
> submitted to MDQ, hardware picks all active MDQs using strict
> priority, and MDQs having the same priority level are chosen using
> round robin. Each packet will traverse MDQ, TL4 to TL1 levels.
> Each level contains an array of queues to support scheduling and
> shaping.
> 
> As HTB supports classful queuing mechanism by supporting rate and
> ceil and allow the user to control the absolute bandwidth to
> particular classes of traffic the same can be achieved by
> configuring shapers and schedulers on different transmit levels.
> 
> This series of patches adds support for HTB offload,
> 
> Patch1: Allow strict priority parameter in HTB offload mode.
> 
> Patch2: Rename existing total tx queues for better readability
> 
> Patch3: defines APIs such that the driver can dynamically initialize/
>         deinitialize the send queues.
> 
> Patch4: Refactors transmit alloc/free calls as preparation for QOS
>         offload code.
> 
> Patch5: Adds actual HTB offload support.
> 
> Patch6: Add documentation about htb offload flow in driver
> 
> Hariprasad Kelam (3):
>   octeontx2-pf: Rename tot_tx_queues to non_qos_queues
>   octeontx2-pf: Refactor schedular queue alloc/free calls
>   docs: octeontx2: Add Documentation for QOS
> 
> Naveen Mamindlapalli (2):
>   sch_htb: Allow HTB priority parameter in offload mode
>   octeontx2-pf: Add support for HTB offload
> 
> Subbaraya Sundeep (1):
>   octeontx2-pf: qos send queues management
> -----
> v1 -> v2 :
>           ensure other drivers won't affect by allowing 'prio'
>           a parameter in htb offload mode.
> 
> v2 -> v3 :
>           1. discard patch supporting devlink to configure TL1 round
>              robin priority
>           2. replace NL_SET_ERR_MSG with NL_SET_ERR_MSG_MOD
>           3. use max3 instead of using max couple of times and use a better
>              naming convention in send queue management code.
> 
> v3 -> v4:
> 	  1. fix sparse warnings.
> 	  2. release mutex lock in error conditions.
> 
> v4 -> v5:
> 	  1. fix pahole reported issues
>           2. add documentation for htb offload flow.
> 
> v5 -> v6:
> 	  1. fix synchronization issues w.r.t hlist accessing
>              from ndo_select_queue with rcu lock.
>           2. initialize qos related resources in device init.
> 
> v6 -> v7:
> 	  1. fix erros reported by sparse and clang
> 
> v7 -> v8:
> 	  1. cover letter header is malformed in last version.
>              correct the cover letter
> v8 -> v9:
> 	  1. fix issues reported by smatch

Thanks. I checked and all issues I've reported are resolved.