Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5862192rwl; Tue, 11 Apr 2023 11:00:43 -0700 (PDT) X-Google-Smtp-Source: AKy350aLlejKINkfJA/qFtbP06tQq0VDlVP5sQLu6iMop+1oZPEkJbqgE4XL9aR/oHPVGSzEJ9gT X-Received: by 2002:a62:1a8b:0:b0:63a:ea82:b7b7 with SMTP id a133-20020a621a8b000000b0063aea82b7b7mr3606553pfa.28.1681236042838; Tue, 11 Apr 2023 11:00:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681236042; cv=none; d=google.com; s=arc-20160816; b=KXyijRrG1qG4ciQbrdB1vC2ZBbSXhDyNNFVk7a8dIgfhDAuxpL3UAUe1cdAG0GzqRi k80qhFNk1nmD0BIvwN0Rs9Ft4uffIA7ovz93GiGmReh63qhxkwtg46BBSd08Fy1mQScl oRoiAPBnzMi3Kbrdb8F2tOEsorO8W9AG9R3lPZXa9mstnblDD84abg/JTUgshlUJklNC pHkKOtTUsFKDXjrEDjFP9/SIUhdWGllylmkKojc7rS8OJFHligL/CKDdMsAeBAgKDQNj OejAbP2TRkSst0XllQ+SEQR8zVO4tZS6ebIMyDuzbApm5BAE4HiyHWMjsqf0di7i5ndO uaPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=ef8XnWFgsT04MkS5RM8aidy/rRVFyqx0755dVLzx4LY=; b=yxyl1mYkb6PrElGHr51UbAAFki2kwr9jOb9cTl3/ti+IOkVbqMKmql2UMu74W3S6LF WQ901NqCADLhO7/3PMnHSB+nGSDbqY1LW4oE6yz2yyd9f5WanCKTd9kaLeuVDLFnlN9Z RSlwE93vWygoXgoDvbO+Fo2DFMNWAZkVFBG4VVX0ha0V3jTyvsUVavEl8zPQEDA4USju XKKt3wve6oJtgcxlpaxb8quSMXrAGaoXXCgl2lSWeiUs4Qb5CBwW3GUkpHnwJW+MKkj5 W6v4GiWHHu+UW65HgcxCziZOHFYZuQE8ZF2QY81ownPv6vp/R7B3mDX/OEaDW/k2xVZ9 Yvpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JSS2wtNw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a63f702000000b0050be676d6casi13742571pgh.689.2023.04.11.11.00.30; Tue, 11 Apr 2023 11:00:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JSS2wtNw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjDKRun (ORCPT + 99 others); Tue, 11 Apr 2023 13:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbjDKRul (ORCPT ); Tue, 11 Apr 2023 13:50:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37997618C for ; Tue, 11 Apr 2023 10:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681235389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ef8XnWFgsT04MkS5RM8aidy/rRVFyqx0755dVLzx4LY=; b=JSS2wtNwBjpDW4/eTbDo7W8AroW9229ab2hLCFK9BVIER3WlhAW+1I1w38esdrQsrXlt2A E8KYYEqyAvW3q46NiORGAIb3mB3LokKjXY1GLI3ZFC6lbVlu3IHP4lsMTpbeoGtDCnlENO lQh8a5GewIeD0ubtKUNaVPiM8c0qiCY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-C_cXOpSdMASPjUK6X9l8Jw-1; Tue, 11 Apr 2023 13:49:44 -0400 X-MC-Unique: C_cXOpSdMASPjUK6X9l8Jw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 668D985A588; Tue, 11 Apr 2023 17:49:43 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57602728FB; Tue, 11 Apr 2023 17:49:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-8-dhowells@redhat.com> To: Eric Dumazet Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4138302.1681235380.1@warthog.procyon.org.uk> Date: Tue, 11 Apr 2023 18:49:40 +0100 Message-ID: <4138303.1681235380@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Dumazet wrote: > > - zc = sk->sk_route_caps & NETIF_F_SG; > > + if (sk->sk_route_caps & NETIF_F_SG) > > + zc = 1; > > zc is set to 0, 1, MSG_ZEROCOPY , MSG_SPLICE_PAGES > > I find this a bit confusing. Maybe use a private enum ? Meh. That should be "zc = MSG_ZEROCOPY;". Will fix. David