Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5894913rwl; Tue, 11 Apr 2023 11:28:02 -0700 (PDT) X-Google-Smtp-Source: AKy350YHYEyTmOBRRs76HLipXMCfM3oNoqzGQeU3DqWtMIDpzML7clEuA2jz6Zz8XeecgXpRtzpa X-Received: by 2002:a17:90b:1c86:b0:240:9bf7:8df2 with SMTP id oo6-20020a17090b1c8600b002409bf78df2mr17224210pjb.37.1681237682073; Tue, 11 Apr 2023 11:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681237682; cv=none; d=google.com; s=arc-20160816; b=QGLlI4pVDu8ZHQBsFLbBl4eTHKVxGWBuUCPGNmr5ZwOH/BX1U5c3VdIijMTuw5uhxj sKu7OmTF1VjPBh38d8ViaEWtZAFNXnCC1AtnhK48+njyWrZffRK1fJxcye0WGSi1qG2I AXHQ2h+ECxrIs5vKPEVyi1+OKxKPBHEjgKvFbT08ROM7mzSzjcxi1xov7Ix2iD0keJn9 Hdc24ZliNgSMC7AV25P//Ty0IWSzQZLx0yPsBUK8Lv1Icqvx5BRsNIODWD49jJsiiPkE wp6dmVNrQ9S3iyrvDgyP17jwSqFNk0Wz1hTzAVp1HECRTh5O5NwbSBPuLJZMfX0Q+ovz CqBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=sWPZ2soZsylidE36LH194Mjh7EQgTMc+CIMfTeM7SyM=; b=pl5QmIZPx8XPubDa6Mi/ScX58OILYQDzXXS9mxUD0SU2W0fXu6rQlw/F8sMNSqDCJ+ YxPz8ZWRiBlpcLMrslMlAjD4mRe80uEpk+veUCSumt+s7vUY7qpDGW30MEGp71G7kHVu HJmMEl72r1khxo9QVUzfw+4RtF42unfLAXj1sIW8QhIoaKYTAckQq0jTRrB6ltIZWpWO Kvc17slSQTDrH913uDYEGbTHOC2B/covgdZV6i4biqI98kLcN5X1nieop9wGjzaPAuLk 7e4u8od0icSVGfEPXMHxa+BddtH6NRxm/NlJPicHIvB/gY85ZzVoi64WlzgYNgM4+MNY lLDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HzGdZXd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gq16-20020a17090b105000b002469f27fa66si6186683pjb.50.2023.04.11.11.27.50; Tue, 11 Apr 2023 11:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HzGdZXd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbjDKS0q (ORCPT + 99 others); Tue, 11 Apr 2023 14:26:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbjDKS0o (ORCPT ); Tue, 11 Apr 2023 14:26:44 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37C2A59C7; Tue, 11 Apr 2023 11:26:35 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v29so8521008wra.13; Tue, 11 Apr 2023 11:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681237593; x=1683829593; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sWPZ2soZsylidE36LH194Mjh7EQgTMc+CIMfTeM7SyM=; b=HzGdZXd5D2JAChH2u2D189QRsK69oIOPAxFRiuTBlybvkXBP8qVTgaYQcM8PWc9bxv e3UpIq6Zi1JCF0Aqz2Zitlv1+j+H3F1e5kx0lqdSVfJr+w4cNESxYHPJwCAU8DpaXmv9 kG2ZVFHTAGFUmpjlhraKKxUqmz+6kfPTp/g7h/o3xGbO3Yhs9+MWTO5P76WKYTsmKqOl vkQ6gFHKgOJfIb11FGjsumfy5tT3hufsMeKs440yJyYYK6rpBY1RL2H1hdl+ppgGokQH ipX67y1HSrDjQN7r1P6+Nk7D4ezab1fF2s6zqxPuAdTftbhf7GCsr3mn7or+64XpxA/k E42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681237593; x=1683829593; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sWPZ2soZsylidE36LH194Mjh7EQgTMc+CIMfTeM7SyM=; b=yb1qILSIg7Cwio1JcjF/mApFbgOnXCqAZDfTzLIQwE56GOaEYio3CupH24ZBdyXEBm 28jk15BGR9YUxcTrWP5YVgJBB6+ntoi15ZiviToiYf0qwohO8zzy40hEHAAyKCrh3spZ kbBzteyJQggKr7Tudy4TcHV2oFM0wRxzeIkDUjhygYRy6uMFnWGaGCbFRkmDf8Dfa6rh 8snVeB2SkESwKp+WTwkkE+CHkt0y30llByBZ5D3iekgvaPDdOtXXrkI+7lD0nXmfJqu4 zmIC3G2SdKHXdjQ3Zf6yCzyNT8tFaGST8CNmDSto8zMxTxx4Wl4oz7jqJ5ER7N5U83P4 BoQw== X-Gm-Message-State: AAQBX9cIJwIJDutmjAqO/HQGsuq4F2ACRC4me4Hxq20AeUckc5oisIqf WlFOwxukzZOxQSgHIh+dwwA= X-Received: by 2002:a5d:66cd:0:b0:2d0:bba8:3901 with SMTP id k13-20020a5d66cd000000b002d0bba83901mr2636557wrw.62.1681237593638; Tue, 11 Apr 2023 11:26:33 -0700 (PDT) Received: from [192.168.0.22] ([87.116.164.178]) by smtp.gmail.com with ESMTPSA id m15-20020adfe0cf000000b002c7163660a9sm15035965wri.105.2023.04.11.11.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 11:26:33 -0700 (PDT) Message-ID: <5f24cb94-d7f1-f8b0-71f0-2b39a89bb2dc@gmail.com> Date: Tue, 11 Apr 2023 20:26:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Cc: savicaleksa83@gmail.com, linux-hwmon@vger.kernel.org, Jack Doan , Jean Delvare , Leonard Anderweit , linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Fix alignment of function call params To: Guenter Roeck References: <20230409183549.12683-1-savicaleksa83@gmail.com> Content-Language: en-US From: Aleksa Savic In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-04-10 18:53:08 GMT+02:00, Guenter Roeck wrote: > > I am not sure I understand how this would improve readability. > It seems to accomplish the opposite. Sure, I know, checkpatch --strict > complains, but that is still better than unreadable code just to make > checkpatch happy. > > Guenter Both seemed fine to me, the idea was to fix the checkpatch warning. If it's OK for it to complain about this, plus the changes would make it harder to read, please ignore this patch. Thanks, Aleksa