Subject: Re: [PATCH] UML - time build fix
From: Thomas Gleixner <tglx@linutronix.de>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>,
       uml-devel <user-mode-linux-devel@lists.sourceforge.net>
In-Reply-To: <20070925215629.GA10926@c2.user-mode-linux.org>
References: <20070925173713.GA8262@c2.user-mode-linux.org>
	 <1190750055.17409.38.camel@chaos>
	 <20070925215629.GA10926@c2.user-mode-linux.org>
Content-Type: text/plain
Date: Wed, 26 Sep 2007 00:08:47 +0200
Message-Id: <1190758127.17409.81.camel@chaos>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1123
Lines: 32

Jeff,

On Tue, 2007-09-25 at 17:56 -0400, Jeff Dike wrote:
> On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote:
> > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote:
> > > Put back an implementation of timeval_to_ns in
> > > arch/um/os-Linux/time.c.  tglx pointed out in his review of tickless
> > > support that there was a perfectly good implementation of it in
> > > linux/time.h.  The problem is that this is userspace code which can't
> > > pull in kernel headers and there doesn't seem to be a libc version.
> > 
> > Oops. Did not notice. 
> 
> It's a UML peculiarity...
> 
> > Can't we move it into some header file which is accessible from everywhere ?
> 
> Not in the generic kernel.  UML has some generally includable headers
> of its own, but that doesn't really help.
> 
> The one thing that would help is a libc timeval_to_ns.

Fair enough.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/