Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230411183144.6932-1-pmenzel@molgen.mpg.de>
In-Reply-To: <20230411183144.6932-1-pmenzel@molgen.mpg.de>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 11 Apr 2023 20:54:07 +0200
Message-ID: <CAJZ5v0hbWerXrBG0K20xHEOajhYunqxNs+R6awA03tYpCwRKKg@mail.gmail.com>
Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, lore982@yahoo.com,
        Tamim Khan <tamim@fusetak.com>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Apr 11, 2023 at 8:32 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
> ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
>
>     $ sudo dmesg | grep DMI
>     DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
>     $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
>                     IRQ (Level, ActiveLow, Exclusive, )
>                         {1}
>
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
> Cc: lore982@yahoo.com
> Cc: Tamim Khan <tamim@fusetak.com>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index a222bda7e15b..cade3a9e38bb 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
>                 },
>         },
> +       {
> +               .ident = "Asus ExpertBook B1502CBA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "B1502CBA"),
> +               },
> +       },
>         {
>                 .ident = "Asus ExpertBook B2402CBA",
>                 .matches = {
> --

Applied as 6.3-rc material, thanks!