Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 21:30:44 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver
Message-ID: <20230411213044.4bf6dc89@aktux>
In-Reply-To: <a16a8071-3c67-0f40-d7da-3459f7dc584d@linaro.org>
References: <20230407050803.170773-1-andreas@kemnade.info>
        <20230407050803.170773-2-andreas@kemnade.info>
        <a16a8071-3c67-0f40-d7da-3459f7dc584d@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 10 Apr 2023 17:34:00 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

[...]
> > +        led-controller@66 {
> > +            compatible = "rohm,bd2606mvv";
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +            reg = <0x66>;  
> 
> reg is always second property in DTS.
> 
> > +
> > +            led@0 {
> > +                color = <LED_COLOR_ID_RED>;
> > +                function = LED_FUNCTION_POWER;
> > +                reg = <0x0>;  
> 
> Ditto
> 
hmm, reg also second if no compatible first? I see it usually first in
such cases.

Regards,
Andreas