Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 15:36:46 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Mike Rapoport <rppt@linux.ibm.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH 19/29] selftests/mm: Let uffd_handle_page_fault() takes
 wp parameter
Message-ID: <ZDW2zvnbbOfQt4/o@x1n>
References: <20230330155707.3106228-1-peterx@redhat.com>
 <20230330160812.3107522-1-peterx@redhat.com>
 <ZDU8CrPcr1Dclehj@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZDU8CrPcr1Dclehj@linux.ibm.com>
Precedence: bulk

On Tue, Apr 11, 2023 at 01:52:58PM +0300, Mike Rapoport wrote:
> On Thu, Mar 30, 2023 at 12:08:12PM -0400, Peter Xu wrote:
> > Subject: selftests/mm: Let uffd_handle_page_fault() takes wp parameter
> 
> Nit:                                                 ^ take
> 
> > Make the handler optionally apply WP bit when resolving page faults for
> > either missing or minor page faults.  This move towards removing global
> 
> Nit:                                        ^ moves

Will fix.

> 
> > test_uffdio_wp outside of the common code.
> > 
> > For this, slightly abuse uffd_stats to keep one more parameter on whether
> > we'd like to resolve page faults with WP bit set.  Note that only the name
> > is abused, it'll be better to be called uffd_args or similar but let's not
> > bother for now.
> 
> Maybe one of the first commits in the series should have been
> s/uffd_stats/uffd_args/g, but I realize that it's PITA, so I won't insist.

It's fine, I'll add one patch.  The rebase does take some more minutes, but
it's manageable.  I'll drop this paragraph then.

Thanks,

-- 
Peter Xu