Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 11 Apr 2023 13:19:21 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Aleksa Savic <savicaleksa83@gmail.com>
Cc:     linux-hwmon@vger.kernel.org, Jack Doan <me@jackdoan.com>,
        Jean Delvare <jdelvare@suse.com>,
        Leonard Anderweit <leonard.anderweit@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Fix alignment of function
 call params
Message-ID: <07419415-3087-48e6-955a-b5024d943e07@roeck-us.net>
References: <20230409183549.12683-1-savicaleksa83@gmail.com>
 <c24a071e-b191-4626-8edc-1658a01d80ef@roeck-us.net>
 <5f24cb94-d7f1-f8b0-71f0-2b39a89bb2dc@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5f24cb94-d7f1-f8b0-71f0-2b39a89bb2dc@gmail.com>
Precedence: bulk

On Tue, Apr 11, 2023 at 08:26:32PM +0200, Aleksa Savic wrote:
> On 2023-04-10 18:53:08 GMT+02:00, Guenter Roeck wrote:
> > 
> > I am not sure I understand how this would improve readability.
> > It seems to accomplish the opposite. Sure, I know, checkpatch --strict
> > complains, but that is still better than unreadable code just to make
> > checkpatch happy.
> > 
> > Guenter
> 
> Both seemed fine to me, the idea was to fix the checkpatch warning.
> If it's OK for it to complain about this, plus the changes would make it
> harder to read, please ignore this patch.
> 

checkpatch is useful, but not in situations where following its guidance
results in code which is diffficult to read. I run checkpatch --strict when
applying patches, so I do notice when it complains. If I want a report
to be addressed, I'll say that (such as, for example, when people are
overly generous with empty lines). If not, you can assume that I am ok with
the report and find it more important to have readable code than being
checkpatch-clean.

Guenter