Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 14:36:23 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Mark Brown <broonie@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio
Message-ID: <ZDWopwozNjFg/9NX@fedora>
References: <cover.1679323449.git.william.gray@linaro.org>
 <ca710d14a710fee44f7911f2a84b6a55570561ee.1679323449.git.william.gray@linaro.org>
 <571b4df1-91ea-481c-9797-842974dfa922@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="U8bW8/8WuuNm+L45"
Content-Disposition: inline
In-Reply-To: <571b4df1-91ea-481c-9797-842974dfa922@sirena.org.uk>
Precedence: bulk


--U8bW8/8WuuNm+L45
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 11, 2023 at 09:23:55PM +0100, Mark Brown wrote:
> On Mon, Mar 20, 2023 at 10:50:15AM -0400, William Breathitt Gray wrote:
> > A private data structure struct dio48e_gpio is introduced to facilitate
> > passage of the regmap and IRQ mask state for the device to the callback
> > dio48e_handle_mask_sync(). This is in preparation for the removal of the
> > handle_mask_sync() map parameter in a subsequent patch.
>=20
> What's the story with this patch?

Currently dio48e_handle_mask_sync() uses the map argument in its
implementation. Once the map parameter is removed, the current
implementation of dio48e_handle_mask_sync() will no longer build, so we
must adjust the implementation to no longer depend on map.

The reason for this particular patch is to keep the reimplementation of
dio48e_handle_mask_sync() separate so that the handle_mask_sync() map
parameter removal patch is simple. This keeps the git history clear
and allows us to address any possible regressions to 104-dio-48e
separately without affecting the handle_mask_sync() API.

William Breathitt Gray

--U8bW8/8WuuNm+L45
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZDWopwAKCRC1SFbKvhIj
K/klAP0RkCm4BErLS4tTTLEWJk3HbRLesstQCvHYBOJikpHA4AD/VLLCn37yeW5D
2v1D9rFD2XkEGF5lvJTWppJl4zQnPgs=
=rYW8
-----END PGP SIGNATURE-----

--U8bW8/8WuuNm+L45--