Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 22:06:50 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Changhuang Liang <changhuang.liang@starfivetech.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Walker Chen <walker.chen@starfivetech.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree
 resources
Message-ID: <20230411-stimuli-reapprove-4659d50e5d2e@spud>
References: <20230411064743.273388-1-changhuang.liang@starfivetech.com>
 <20230411064743.273388-6-changhuang.liang@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bDUiOgF7hkvaIlrf"
Content-Disposition: inline
In-Reply-To: <20230411064743.273388-6-changhuang.liang@starfivetech.com>
Precedence: bulk


--bDUiOgF7hkvaIlrf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
> Different compatible parse device tree resources work in different ways.

Right now there is only one compatible, so this commit message needs to
be expanded on to provide more information on your motivation.

> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

>  static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
>  {
>  	struct jh71xx_pmu_dev *pmd;
> @@ -296,23 +325,20 @@ static int jh71xx_pmu_probe(struct platform_device =
*pdev)
>  	if (!pmu)
>  		return -ENOMEM;
> =20
> -	pmu->base =3D device_node_to_regmap(np);
> -	if (IS_ERR(pmu->base))
> -		return PTR_ERR(pmu->base);
> -
> -	pmu->irq =3D platform_get_irq(pdev, 0);
> -	if (pmu->irq < 0)
> -		return pmu->irq;
> -
> -	ret =3D devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
> -			       0, pdev->name, pmu);
> -	if (ret)
> -		dev_err(dev, "failed to request irq\n");
> +	spin_lock_init(&pmu->lock);
> =20
>  	match_data =3D of_device_get_match_data(dev);
>  	if (!match_data)
>  		return -EINVAL;
> =20
> +	if (match_data->pmu_parse_dt) {

How can this be false?

Cheers,
Conor.

--bDUiOgF7hkvaIlrf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZDXL6gAKCRB4tDGHoIJi
0hKsAQDfXKLTbzKOVFnOKyo4Q8rhO79dEC4uKOIjSEkTkNr0sAEAmTPcrqwT9S1J
id3pUSxlo+QqgTZJtIAEFaPBifiRGg8=
=MAxW
-----END PGP SIGNATURE-----

--bDUiOgF7hkvaIlrf--