Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362AbXIYXPT (ORCPT ); Tue, 25 Sep 2007 19:15:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752263AbXIYXPG (ORCPT ); Tue, 25 Sep 2007 19:15:06 -0400 Received: from mail-gw2.sa.eol.hu ([212.108.200.109]:59214 "EHLO mail-gw2.sa.eol.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbXIYXPF (ORCPT ); Tue, 25 Sep 2007 19:15:05 -0400 To: haveblue@us.ibm.com CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: missing mnt_drop_write() on open error Message-Id: From: Miklos Szeredi Date: Wed, 26 Sep 2007 01:14:40 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 477 Lines: 13 I get this at umount, if there was a failed open(): WARNING: at fs/namespace.c:586 __mntput() I think the problem is that may_open() calls mnt_want_write(), but if open doesn't succeed, mnt_drop_write() will not be called. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/