Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230410023724.3209455-1-jun_c@hust.edu.cn>
In-Reply-To: <20230410023724.3209455-1-jun_c@hust.edu.cn>
From:   Justin Tee <justintee8345@gmail.com>
Date:   Tue, 11 Apr 2023 14:31:55 -0700
Message-ID: <CABPRKS9TbZO7NmknHfNEaxuY3EGGmR_NOcbBuM1ooba_R-3yiQ@mail.gmail.com>
Subject: Re: [PATCH] scsi: lpfc: silence an incorrect device output
To:     Jun Chen <jun_c@hust.edu.cn>
Cc:     James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        Justin Tee <justin.tee@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jun,

Broadcom no longer supports LPFC_SLI_INTF_IF_TYPE_1 adapters, but the
patch looks fine.

Reviewed-by: Justin Tee <justin.tee@broadcom.com>

Thanks,
Justin

On Sun, Apr 9, 2023 at 8:14=E2=80=AFPM Jun Chen <jun_c@hust.edu.cn> wrote:
>
> In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a
> break statement, resulting in an incorrect device output.
>
> Fix this by adding a break statement before the default option.
>
> Signed-off-by: Jun Chen <jun_c@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
>  drivers/scsi/lpfc/lpfc_init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.=
c
> index d062220d3232..da3a45441639 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
>                         iounmap(phba->sli4_hba.dpp_regs_memmap_p);
>                 break;
>         case LPFC_SLI_INTF_IF_TYPE_1:
> +               break;
>         default:
>                 dev_printk(KERN_ERR, &phba->pcidev->dev,
>                            "FATAL - unsupported SLI4 interface type - %d\=
n",
> --
> 2.25.1
>