Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "Kang, Shan" <shan.kang@intel.com>
Subject: RE: [PATCH v8 33/33] KVM: x86/vmx: refactor VMX_DO_EVENT_IRQOFF to
 generate FRED stack frames
Thread-Topic: [PATCH v8 33/33] KVM: x86/vmx: refactor VMX_DO_EVENT_IRQOFF to
 generate FRED stack frames
Thread-Index: AQHZa4iiYR92PWeRCEi6WbUcy97+Bq8lFcEAgAB3RxCAAORfgIAAR0nA
Date:   Tue, 11 Apr 2023 22:50:01 +0000
Message-ID: <MW4PR11MB6737F5CD4B75A77D8A231AF5A89A9@MW4PR11MB6737.namprd11.prod.outlook.com>
References: <20230410081438.1750-1-xin3.li@intel.com>
 <20230410081438.1750-34-xin3.li@intel.com> <ZDSEjhGV9D90J6Bx@google.com>
 <SA1PR11MB673493A64E2BEAFA1A18ADE6A89A9@SA1PR11MB6734.namprd11.prod.outlook.com>
 <ZDWoL6o5LYgWP14y@google.com>
In-Reply-To: <ZDWoL6o5LYgWP14y@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ep0Xzc2DEjaq/sPacgbaXLLHcMzwdHCtSTehztRStwMMYiENxSUIVVLUo6xu?=
 =?us-ascii?Q?DYQGk8q2ZrOE66G8L4IKAiNXyxMR6JESGFjap9zcSDKWBJwNUlVWSKhBrsss?=
 =?us-ascii?Q?f88bjTG3UznPe7jPGPIiZFGpp2UFUuNm2OVw8xyhJZAc2qkFaMZCn58yhzhm?=
 =?us-ascii?Q?1bc5zDQuhvhJvsxc4wtUGoxeJ/NJcZLlUKnC5GZL4DTIWhz93i+XzFiVQgsV?=
 =?us-ascii?Q?YYbPp8Di2v5aNBEyiO6eiRZnHb/DTskDw33DM7FNaswJSuPK/e57CFqdwuWG?=
 =?us-ascii?Q?y3e4yGzXrYi7S+6rfqJDUBDpfGVY/eErqE5e2nldJN6MDvtGvkXG1JJDOgEB?=
 =?us-ascii?Q?nCivvi1Y9/ppsYU+Xf0WYQohOH6EtxfGedzbQO9Sgp99pzOCKiGHrDyHU8fl?=
 =?us-ascii?Q?hqMMvFvb12VUb87vD7cBwlQBayVIeaAZXqgG84BG7N9o3I8IgxT7QDNEmnoe?=
 =?us-ascii?Q?bQ5HU5VK7NrHn/OYZjf7CNZGVe0VprBtBMTPRCDVflauehjzfiCDrilI6SR+?=
 =?us-ascii?Q?NJnkdpdZqjWEehF3hDpIuvSJC1rCC8LBkuNimWiChn9+XWHeIdWr6N2BtmY9?=
 =?us-ascii?Q?Nbr5y4Kwfz0kfKY/aVyomVt9kXYqg5CYICtyZ9owIIDfBY58yMeugoyZ/5T9?=
 =?us-ascii?Q?7gqyhK/9xhSAaQizSlTGbgovo8m8vD9yyi9nnsrQi9n/v3TQZ0gEwxzfht6h?=
 =?us-ascii?Q?MT9coJDSmqx4XqGSZOiK/Ku5KF6YsqOfj6ZkFcXvrqxTizbBt+yTKDxPql35?=
 =?us-ascii?Q?eXPrjSbW6RrQJ6xgX3m3yWd/7NHD82ZSoToGyK8KHDi+l0L06/QKjBeRhdyx?=
 =?us-ascii?Q?qRxgWmQfBULCnvnS36NLWZ5IpgX3ADxhueINMGOvHQVVxJdlb3a25CNRz9ti?=
 =?us-ascii?Q?lUCDYdf8cVF9c/pHtKTzqCNcwDYX37W/8xqva+ltu/P9y12KguktGNvh9wQ9?=
 =?us-ascii?Q?IZlsJcRNWlKbYLsk1cj8a7xxSqT2nxM5AAf/d/RLMbBrDcypX1Hq7hVabWFd?=
 =?us-ascii?Q?qHL0te7dOE40frWs2CBJkIAvCKJszxNnT7CZXX+5VZGVkMBYrn21lTwEVvYZ?=
 =?us-ascii?Q?tqI+cjlysNdvVvVPL331b6O6IlZdHfqmMZg5NP0BuzZMM+8MUWuGQWDQychn?=
 =?us-ascii?Q?OJloKV5vgLdCFdellSzMQt69mE/acgTKFjWbKuJWeeM/WjbF5YKD2eXcpBap?=
 =?us-ascii?Q?b5FhwJc2dJyzmV1++0YhzeX3486wdjFiIlmh4AnzMYXB9sCcfOhaI3ZVbpiW?=
 =?us-ascii?Q?kW7r/atZMdm0WoWCRyLzrgVnYejJmUhBdtyVizjX69brWfWHjQaf8fUJqoyy?=
 =?us-ascii?Q?xgxt0VUWSXAny3rqwWHltQ74j0ZJJNDZ7InGY3xl/xdzVB0qwhAMGg2PDusg?=
 =?us-ascii?Q?BS9+xLEOTT2LSqS+T9JRr/0/N2xWySG1DkTX77/s76lneLA/AV6qocWGgtgy?=
 =?us-ascii?Q?GmdEhgyhV916lMwXKIYsreu6IXYTCEW11yeSdruzzyl8EmP+lGo4hZ88LVSt?=
 =?us-ascii?Q?Ffw19Bz1WLRX1FHY7mVoUAMclDwfaIC8HpoL46qfjedoavjc78y3T1EpLFT4?=
 =?us-ascii?Q?Py6moEle47HG1WiBmtQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6737.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1162ec9f-cd49-4028-84a1-08db3adf1549
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 22:50:01.1803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +YH+J+uJtwzbdFEwkEadjhZlCI4wy49wW4Pxwh2AaScYOzeQmWWF2q/JkJRsmCYBw/bx5FC5Gi1mGLz3qbWeRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5020
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > external_interrupt() is always available on x86_64, even when CONFIG_X8=
6_FRED
> > is not defined. I prefer to always call external_interrupt() on x86_64 =
for IRQ
> > handling, which avoids re-entering noinstr code. how do you think? Too
> > aggressive?
>=20
> I think it's completely orthogonal to FRED enabling.  If you or anyone el=
se wants
> to convert the non-FRED handling to external_interrupt(), then do so afte=
r FRED
> lands, or at the very least in a separate patch after enabling FRED in KV=
M.

That sounds a reasonable plan.