Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f96efb81-ac39-e64a-a8fc-f2f638e1f3c7@intel.com>
Date:   Tue, 11 Apr 2023 16:41:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH net-next v4 07/12] net: stmmac: Remove some unnecessary
 void pointers
Content-Language: en-US
To:     Andrew Halaney <ahalaney@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <vkoul@kernel.org>, <bhupesh.sharma@linaro.org>, <wens@csie.org>,
        <jernej.skrabec@gmail.com>, <samuel@sholland.org>,
        <mturquette@baylibre.com>, <peppe.cavallaro@st.com>,
        <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
        <mcoquelin.stm32@gmail.com>, <richardcochran@gmail.com>,
        <linux@armlinux.org.uk>, <veekhee@apple.com>,
        <tee.min.tan@linux.intel.com>, <mohammad.athari.ismail@intel.com>,
        <jonathanh@nvidia.com>, <ruppala@nvidia.com>, <bmasney@redhat.com>,
        <andrey.konovalov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>, <ncai@quicinc.com>,
        <jsuraj@qti.qualcomm.com>, <hisunil@quicinc.com>,
        <echanude@redhat.com>, Simon Horman <simon.horman@corigine.com>
References: <20230411200409.455355-1-ahalaney@redhat.com>
 <20230411200409.455355-8-ahalaney@redhat.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230411200409.455355-8-ahalaney@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckFuM0R3c1BkclBpUno4S3h2MGtYK1R1STRLYWRUVVlrS1JlK0NtZ2Z6V3NC?=
 =?utf-8?B?SkZnU3FJOE5DWFIvUXBXblJSQUZRVWRnekFiWmZDY3dMeTdEZDZGSEVXbUhk?=
 =?utf-8?B?WmRXYlVRczhRRjQ0Y0h6VnNwbjRNZ2tLTExyb3FBcVBvRFBNSlR1eld1VG5j?=
 =?utf-8?B?eWRuOGZ6RlFrT08rUlVHQXdhYTVDQTYrMzd4VWdkMGU1SGtXVDZ6Z1BSSU1v?=
 =?utf-8?B?VkNrRmpxaXFKL1gzdXVkNmx0OHdXNVR1T05QMG1sbjl6UE9hMSsrK2R1aG9p?=
 =?utf-8?B?bTJGTm9tM0UyUEU1WVVaclJHd1JJYk1EcTNFb2xPSWk1WHp1SDZMcmdWaHBD?=
 =?utf-8?B?ZlZCS1J2Ylg5anI0VHRqV2NTNWxhbmVaSjcvYTJwQ0ZvMTJmdSs2QThleXht?=
 =?utf-8?B?b1g3NVVuRXl2OGlzYkpFOGZYSlpTTzFIM2Voemk4Z0ZrSGNLSCs0SXJBcTZ6?=
 =?utf-8?B?ZEs4bEtScGFEdDdTeUlCMExxQ1oyV3hCL09iajFibGVFRzVSUUVLQmlBWUpW?=
 =?utf-8?B?SG5HR0w5bUpDUUFKdzNmUXRob25XM0ZScFBINGEzVGdJVjZBeWxialo0ckJT?=
 =?utf-8?B?TmxCb2UxK3U0T0czQlVtRGg3V3ViWlhvRzVIcWZraS96MUt3Wk1wdXNnaXNT?=
 =?utf-8?B?OFU2WThFL1ZlWnRnK2F5d1YvYTdvWVRiNTd0TjJoWlJodStWTTZ1bkhZZEV6?=
 =?utf-8?B?aURZb2oxN2xMVDE1eGVSZVlQa2I2NnpZTnhzTUNkcmR5UG1UenBnc3hReE9t?=
 =?utf-8?B?WXBTZytYeXBKWTBqYWxWdlg1aGtmWlJQeTgxZTNpZ285S1YxM3pNUVRLYldw?=
 =?utf-8?B?QW9OeWtERDJDUW8wVWhPbWQvazdjQUQxTm14VlBFZXJRU1Q3SExheW94RzZa?=
 =?utf-8?B?ZVU3RjZ5UmNFVHdyVGk1dmdPZXhLQUM4dVhSM0tuMkpRR2pWMk5LaUd5d0Iz?=
 =?utf-8?B?L2FSOEZtcm1FaktJTDJibFJHMXpUd3RSdUczQnhnOHhkeERld1VRUU1wWFcx?=
 =?utf-8?B?cnIrN2FpM2UvUjI2VzVQR3VuYVlEUDJwOGlLUjRlc2hUSzMzRmd1d21yZ0x4?=
 =?utf-8?B?ODd6VmdpSG9UQ1RIZG9XVU4xUE45M1BhcHNSYzB2cm5JQ2N5K3RDWmlFTDAz?=
 =?utf-8?B?bzU0bzlpK1lQNEVtN1U0YVpEdjVvZFJ5VWIwMHY4WmhCeFZuU0JhaDNaSXRE?=
 =?utf-8?B?YlY5SCtXbFFvUUd5R1cxaHNvN3hrRUVWK0liUmdLOW42c2JSNUsrRlJWUXBx?=
 =?utf-8?B?UHc5aXRKQUFYUWtzejVZd3J6TDRpU1RsaDBubXlhMk1BeldFRXA2ajJubGRW?=
 =?utf-8?B?OVVyQ2gzTXo4cFVQSTRKTXBMb2t3OUpLQ2xjUGNBU0t0aENJSGNmM2FpZGdT?=
 =?utf-8?B?UUs5ekV4a3lwMnBVb0tiK1N0WktWNmJYTUNLVFVLOEZuRldid0REV3JVVlV3?=
 =?utf-8?B?bEpzemY5dEpXZnJSN2pKWm5nMVhVUFJ1cC8yU1U1TlBuM1ZEdS8yaGZyVE1B?=
 =?utf-8?B?ZFZ6eXVKSVlJYll0NVZoYjl1WG5PUFd1TTlnWXRPYTNNUjRqbmJuRkQ4ajcr?=
 =?utf-8?B?d2U5T1hiMFdxS2p1SnkzM2dWdVI2UnF0SVU4NkJ6U0N6SU15ak9XU05tcWNE?=
 =?utf-8?B?K3JBSXBMMXRsb3laR2VUUzExUDBvS2tha3RTNWtFeUZWSEY4b3VLQXVzbzUw?=
 =?utf-8?B?YTNmQzltU0ZFNm41U0JVNU5zNWRZQ3VuVkhXeFNCeW0vVnIyZmN1UWl2c3g0?=
 =?utf-8?B?WEpQdXN2bU1FRkhwSHc0c2p4d1dOaWFBRUtkRTEwK2tDNlRYSDJMSE4vVmR1?=
 =?utf-8?B?cXNKYTNpb1ZKMmVYZE5FU2RwSnI5V3phaXh1NzFneFhMekdtR0FFNnBmZHow?=
 =?utf-8?B?dGwrK1AxcXp0V01XOUc3NDhWVjcvT002ZjB0bGY3ZFdaUmlXSXoxeEQ1Vk9m?=
 =?utf-8?B?VWs1UkR3VUY5c2JUVjAwaVZoODE2VkZZeU9rQUNYU2lVY24vSHZDb2pqQmlG?=
 =?utf-8?B?RHZRbHdFa0x4SnN6OWdieW1aNGRrNmhPUHNoeU81VFRIRytUNkphaUhSeVJW?=
 =?utf-8?B?aHJtb2NHWmNTckdBMWZVcXJkYU9GZ0pKbGpObzJjeitLSmU4aG4rSDM5a3N4?=
 =?utf-8?B?dC9KQVhQd1RXN2V4TnBmVk8vcW1HMGcrMzJSN09rZ3JFOE03SVNxWVltSlVm?=
 =?utf-8?B?Qnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec3b715-5b56-40ef-aaf1-08db3ae65567
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 23:41:55.6022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3xEzWQc9Arno4i7g7C57eRGpZBFkmouyMkHVPdK56etmCuKQZ+Hx4mHucGVKWtS9Yp8P+E+oL6PKRx9yBV5iC05fWpz3qInNfd9VqStP4P8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7044
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> There's a few spots in the hardware interface where a void pointer is
> used, but what's passed in and later cast out is always the same type.
> 
> Just use the proper type directly.
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

Much better!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>