Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2acb0ea-90ea-dfbf-6367-c3d44f0e8436@intel.com>
Date:   Tue, 11 Apr 2023 16:42:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH net-next v4 10/12] net: stmmac: dwmac-qcom-ethqos: Respect
 phy-mode and TX delay
Content-Language: en-US
To:     Andrew Halaney <ahalaney@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <vkoul@kernel.org>, <bhupesh.sharma@linaro.org>, <wens@csie.org>,
        <jernej.skrabec@gmail.com>, <samuel@sholland.org>,
        <mturquette@baylibre.com>, <peppe.cavallaro@st.com>,
        <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
        <mcoquelin.stm32@gmail.com>, <richardcochran@gmail.com>,
        <linux@armlinux.org.uk>, <veekhee@apple.com>,
        <tee.min.tan@linux.intel.com>, <mohammad.athari.ismail@intel.com>,
        <jonathanh@nvidia.com>, <ruppala@nvidia.com>, <bmasney@redhat.com>,
        <andrey.konovalov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>, <ncai@quicinc.com>,
        <jsuraj@qti.qualcomm.com>, <hisunil@quicinc.com>,
        <echanude@redhat.com>
References: <20230411200409.455355-1-ahalaney@redhat.com>
 <20230411200409.455355-11-ahalaney@redhat.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230411200409.455355-11-ahalaney@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWREWGNBek9XV0hraEd0RjlKWmt4aDhuRXBxK2lxRXp5aGIzRmFBZWZkVlla?=
 =?utf-8?B?ZFYxK0VSNWNKMkp3WkI5L3JBTkppSzUvR1lLNkg1QjdDVEhsY1NGd1ErY2xB?=
 =?utf-8?B?R1NRNW5WWngydkZrbHVQMXF2U2xEaVZLMmZQM0p3S3BtajgrQy9tVmU4cnox?=
 =?utf-8?B?OUV0Sjk0cGpXVVhTQmcySVRyV21POFJHWjEzOXJLZHA5dUhnSXorL2kwRVpX?=
 =?utf-8?B?dkZlRlRra2tOVUhzM2RxeFJCK0E0NTRzSVYvUnVSbElrMXQzL0svb3NOWlg2?=
 =?utf-8?B?aHFFS2ZYWjBHMG8vTTFkcmpJU3RkOGhRZXc0bnAyQ2tXcUl5Tm04QWdRR0lw?=
 =?utf-8?B?eit3UlQ2azh3aGtyNDN1OVFIWGt5REVVcTVtWUxKdGYrUldzOGw4dGcxU0ky?=
 =?utf-8?B?VG8rK2V0WUZGdXBIOWxwS1lvOWFFdWdPbzRSaVVEWGJlSHo2MGQ5UW1tOExt?=
 =?utf-8?B?ZUh6NDZhZVJzTXFsa05wd2dkei9tVlczSkw0RXREVDFMVjVlRDBmYkRzWkli?=
 =?utf-8?B?aFByVHlyTWdwOFV2cGFtbGhEOWhVWGRGeHVOOWEveldlNWd3MjVPZ0x4STAw?=
 =?utf-8?B?NU1GWTA0aVNMWWIvMjlZUVJEZkM0ZG1lV052NmxpZXdXZ29Cc1BzMWV0cEhp?=
 =?utf-8?B?SXRwWDFNcHp5KzBSME9LVjFUaGF6eXdjOXVPWnl5Y1BWdmYrQXZoMzRnbGpE?=
 =?utf-8?B?WjZ2d1dkOEhPd1EzYy9OTmMraU5WQ1pTNElPbWE0WjRGKzlic05yK2RvbklL?=
 =?utf-8?B?YmFzS0lzQ2YrR0pPSFNpbWdITFpuSzY5WktsUlZnb3JqVHhoVkpZdmUxYTVl?=
 =?utf-8?B?cFZCK1NudmNLaHVWcXZoejRydy9ncWxBOFNMMmxSQmFiWk1oeHBBSjcxekRs?=
 =?utf-8?B?MDZWdHBRRjFqVHUwd0NEd2REZXlZWHJ1TnRhVHJOcUoxSzVZV1R0dnh4QzBQ?=
 =?utf-8?B?eDRXbEVOMWJyTnc2eEdrQmhUSDVidTBlU2l2WG4yNVUwMHRQTHlTV2VURzVE?=
 =?utf-8?B?YU1sOVZuRHhyRlVTZ2V5dzZVcUtWQ1dMczVsWlJSalhUOHMxYzZYRHUraU1q?=
 =?utf-8?B?TUE4TVZsaDRCS3RYYVYwcWdsMHFCdlBzemJvSHFMTzhXb1M4Mkw1RVNCT1Jx?=
 =?utf-8?B?cDNEUDd2WlJqT1QrczNvcUsycmRHbWNxYU0rMEJQbHo0N1g4SFFFM1JIS083?=
 =?utf-8?B?dGp2UWNEK3JKNTBNU1o3Z3pVVmZFa003UVppN1IrLzk5NWxuTno3SmhRYmtI?=
 =?utf-8?B?S055bEZ5NWZjWExLVFZTeWNTK3laNGhPL2RuWExidWw0WU5zSFgxelY0c0k1?=
 =?utf-8?B?UnZ0VE1MQlFDaGtMSk9qZ2FHT1ZzZnMwb2dpdFBwLzM5Yi9ubWRpVk1veWpG?=
 =?utf-8?B?aTlCQXdoN1Z6TDEyRlNLaDNsVUpLYlRqK3hJWXBxK1lyek03cDB3QmZBZVkv?=
 =?utf-8?B?Z1FKYTNKOERVUzdVdHM3ZXhTUXppbk9lUTlNNFdUNmh6M1V0SUZqUTRYWDdj?=
 =?utf-8?B?RmozZ0FGY3ZZMWNVbVFzcW52S1dWOGRJL2VkUnFZQS9ZejNrSHQ2Q01pWWZh?=
 =?utf-8?B?T2RzMEorS2Zxclp6MkRhUWZJR1dBRHVhOUk0S0FlWGJnT0g5WHJHSGR4VVo2?=
 =?utf-8?B?c0RDNlJlNjB2MzlIOXFiZVVabUFVM2poSGRCajM3Y3JMb1lMSWxaT011N1lH?=
 =?utf-8?B?djJQZ0dFWTY3bUZ5YThJWE1TRHk1VWVNU1hPOXZyR1puYTVSRE5vcDRIWlRo?=
 =?utf-8?B?Tk5mRFFNdXVjU3RUQTlCUW1mR1R6S0QyN0VZUEM5NjdJVmd0djA3UmtGbm1S?=
 =?utf-8?B?bC9YL0lrQWdIWDF5amtBczExbmplOEV3NDc0cWJKcVNFd3UxNGtrNnYyblVn?=
 =?utf-8?B?MlNTbWZvbDduSzVJcWcvcVJhQzhETktLWkRPeFBBY1Z0ZjlWWENHaWFDTlhx?=
 =?utf-8?B?R21XR2dzcGF4S242U21iUWsrU2YwMWNGSFFTWHd5NitybDlkZWxnbWNqK1Ew?=
 =?utf-8?B?dGtyRVpLS2pKek9KbWVjcEYyWDFaRnR2QTZqdWJLMlk1ZUxod1BVb0JRN3py?=
 =?utf-8?B?anZhbmljNGFLd09jWGdNZXBKWEkxZzlaaHBhYnVaM2NWVmdWcXVSc2hBSWhS?=
 =?utf-8?B?OEV6OXBUSXp5ZXJYaGFwdmNlQzNZKzBlR1V5T3lvUmdqN0QvOE56UWV0MTlj?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6179e9b3-b3fd-4570-ca40-08db3ae66f49
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 23:42:38.9858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eCDnL9mN9JJO8PTx94wwYQY7ccijzT9+mCLYsUPN66IsFbbfirpgJEHNFnZ1HTxwDe+XGkFIIc4e76AiiurlSfJOy9XGmVuf4SXHKok6/5s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7044
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> The driver currently sets a MAC TX delay of 2 ns no matter what the
> phy-mode is. If the phy-mode indicates the phy is in charge of the
> TX delay (rgmii-txid, rgmii-id), don't do it in the MAC.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>