Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9819f309-7542-4182-0e7d-a85b6ac9bf58@intel.com>
Date:   Tue, 11 Apr 2023 16:45:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH net-next v4 11/12] net: stmmac: dwmac-qcom-ethqos: Use
 loopback_en for all speeds
Content-Language: en-US
To:     Andrew Halaney <ahalaney@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <vkoul@kernel.org>, <bhupesh.sharma@linaro.org>, <wens@csie.org>,
        <jernej.skrabec@gmail.com>, <samuel@sholland.org>,
        <mturquette@baylibre.com>, <peppe.cavallaro@st.com>,
        <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
        <mcoquelin.stm32@gmail.com>, <richardcochran@gmail.com>,
        <linux@armlinux.org.uk>, <veekhee@apple.com>,
        <tee.min.tan@linux.intel.com>, <mohammad.athari.ismail@intel.com>,
        <jonathanh@nvidia.com>, <ruppala@nvidia.com>, <bmasney@redhat.com>,
        <andrey.konovalov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>, <ncai@quicinc.com>,
        <jsuraj@qti.qualcomm.com>, <hisunil@quicinc.com>,
        <echanude@redhat.com>
References: <20230411200409.455355-1-ahalaney@redhat.com>
 <20230411200409.455355-12-ahalaney@redhat.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230411200409.455355-12-ahalaney@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0ZlRTVTZXhocXhzbUhPaXJXcmdnM1lYQ3c0RE9HSEVRUXVGb3RVVk5pSGxL?=
 =?utf-8?B?b0ZjY1VqdFBsMENtMWoxTEx1VFJobUNLYVN4YWk0S2FUMW81YTNqQ1pidnhv?=
 =?utf-8?B?NXdqNUNVTnBQblBsdUtrRitvL1lxSTdkaW9wSkU3RFZQQVNKT0J2QnZwbjgr?=
 =?utf-8?B?bGoxcXNyNks1RlQ3V1dtNWU2Tk1YNFZRZzZFeUR5SjlxelRtTkNGSi8wVG9q?=
 =?utf-8?B?UDE3ZjUxMGFtcHhnZHBEb25US3cvWEkxYzYvTExhWjhlaVlWY2s2STdvU0px?=
 =?utf-8?B?SDhBMjFWTjI3Smplc3lTV2RaV0hlNWF2UDdDanVGWU9qMVd4Y3BhNTRhdUl0?=
 =?utf-8?B?MG45MXQyd0lPbVBBekRLcGhOVEFpK2o2RUtjRTk1djd3aWs0d3pCNVBXVEM0?=
 =?utf-8?B?enlwV0ZsWWFMZmFuY21NS1VEWmVJN25FZXRjcDN6a2hQS0VVejU2TWprWjVr?=
 =?utf-8?B?MFBpUHE5Rnk0eFo4S3Z6QTJUYkNSQ2h6V1ZseHN1M2xzaWhUNnFPVFhES0c0?=
 =?utf-8?B?RzBnUlBSeGd2NVFnQ05LZGdBb3hsQmJCOWxoZDZ6a3pnRVBhSXhydmN2SmRx?=
 =?utf-8?B?OUllMldXanpFNEVvKytaT1E1OEZXcTJQeTZoK0tIOW9FcHRQZy90cjBZYk5J?=
 =?utf-8?B?U1JCUUZVc0x3MEs4RGVpVHVCVVVsc3BkY2hKWS82czIxdHFxU0VhTG9uWU11?=
 =?utf-8?B?Tm9reG56NTlJOWdwd0RGNGZ6c0lxa0gveE5lZnhlSWpjaFlXVU95RmpicHJ1?=
 =?utf-8?B?M0VkM1k2V2xlY09ZZnRSd08xUXhjblNvcjR4WWNOUkx1ZEI4VkRoOFJleUhJ?=
 =?utf-8?B?ZGZwTE1xbWQ5RG1jMHVFN0tXc2RQdU9RdTJZcWxHUkZ2ZTdxaVJuZk5Dd1Mr?=
 =?utf-8?B?QlI0M3J6SFVhemM4dE1xQjBWcklDOXRodmVIdDRlVXhJaWlBZUN1aXhLUWRU?=
 =?utf-8?B?WkRmdjd2NmFMckZUVFIvVXdRdG5zVTNxWlpHMnFURy92VHlnbTlRYStlWjg0?=
 =?utf-8?B?aDVBTnZmeitSYkZybEZrbTdMUXk1QTdqaVBqTEJ4dkhFUUxveTBGY1FwelFs?=
 =?utf-8?B?NG1PVldGa1E1UllCUUNpN3h3aUJTLzhKOVFmdkM2enFscGNRU3RjNG1IZ1BT?=
 =?utf-8?B?L0dFMEx6d1lKR0pka0pIdjVHazRxc3FUdWxmYmJNaXd3RGkwNEcvSUd1LzVi?=
 =?utf-8?B?QmVWZ0hHaC83VDVzSjFFS2x4cXplYWpZbGFGNEgwdlQ3MWxKVEp5M3NmeFJW?=
 =?utf-8?B?LyttTjl6MzhxY09WT1hGRTJ3MHBVcm9rRkp6aWtoTVRpQUxURmhoQ3pmZEpK?=
 =?utf-8?B?a294V21kT2xqMFpQZXRIMmdHak45U29nQU4zTnc0WExkbk1TTk9RbTBkdUZP?=
 =?utf-8?B?dVJSNy9IallrTmJaakhuV3dZTG5wNmZoTmpjNC9GbFZHS3d4QzI0WVovdFV6?=
 =?utf-8?B?Wk15ZXhnRU1oenArU0dNZlZkUlc1bnlOMDdaazgwOUxrcDRDZkZTd09rT1NG?=
 =?utf-8?B?a1kyNkNtd2tOblR5M0FJU2FmWktGdGlYYkxub09VRDVUWVRISzAvN3hRQ1lK?=
 =?utf-8?B?MVdDSmVYeVFYV3BrbnVzNXFybDl3bW9FaXdUb1N5aXNkaGtPODVUTDR6emZt?=
 =?utf-8?B?NzlneU9odkRZY2VhdDNJL0Voc1V3cEIxQ043a2RnUFhqMFNRK3Q2Ky9qTzBW?=
 =?utf-8?B?RTl6dDN1empId3NHNW5wWXVnTEltclNTd2M5c01WNWg5ZWVVOFVoYWVFOURX?=
 =?utf-8?B?eHl3d2RHazFmeXZZeGFuN3FBY05hSFpmVHJtaE10NnJBRWxmVGtjNE4zMlpz?=
 =?utf-8?B?OE8rTVd5QlprRmRMRHUra2kwaUM3dllEdC9OeThIdWszRVBNRTBpbEp5djBu?=
 =?utf-8?B?bGd0Um1XU3JUVEY4Y0c2ZWp6eDFVMGkzZGpDcTk1cENVOEZGREF0c0RDT0FS?=
 =?utf-8?B?N3ZxaWpXdE5xZUZza3lqczhIM0RiRzI3Wlc0cUtTSGtUTFY1NytrYnJ3aGxa?=
 =?utf-8?B?aTB6RUFmRG5CWWJLak96UWZTWGNwemxudFBGOUxndkdqcU1YSXdYWUk2K1lR?=
 =?utf-8?B?UXB2VGNQcy8xWlBmUHhXNEYzajJNczdEa1d2enNacTg1TUdPYzBCcWxFMkFG?=
 =?utf-8?B?SlhpRFdiSzAyZjFLeCs1dUhSR0xLWFZqZ1UwQ2k3b1kvRUViQTRsOWcxQm1h?=
 =?utf-8?B?OVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cdecfa45-3500-4366-04a5-08db3ae6d9af
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 23:45:37.4484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yQG+SNKo7IL+87/PsiRjW6eJOMSc3mNJyqAbedBF7AtvLQIC070+XtKbA3eR6sDPKfXNctSCsGABgX01GjpiJVBSxHN4wWlc+qcHF6FSlbk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7194
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> It seems that this variable should be used for all speeds, not just
> 1000/100.
> 
> While at it refactor it slightly to be more readable, including fixing
> the typo in the variable name.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

Would prefer the future use of bitfields in a u8 instead of a bool in
structs, but it's really a nit, and they're already there you're just
renaming them.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>