Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fcfa0adb-e204-3232-5c33-711c209b8214@intel.com>
Date:   Tue, 11 Apr 2023 16:47:58 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH net-next v4 12/12] net: stmmac: dwmac-qcom-ethqos: Add
 EMAC3 support
Content-Language: en-US
To:     Andrew Halaney <ahalaney@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <vkoul@kernel.org>, <bhupesh.sharma@linaro.org>, <wens@csie.org>,
        <jernej.skrabec@gmail.com>, <samuel@sholland.org>,
        <mturquette@baylibre.com>, <peppe.cavallaro@st.com>,
        <alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
        <mcoquelin.stm32@gmail.com>, <richardcochran@gmail.com>,
        <linux@armlinux.org.uk>, <veekhee@apple.com>,
        <tee.min.tan@linux.intel.com>, <mohammad.athari.ismail@intel.com>,
        <jonathanh@nvidia.com>, <ruppala@nvidia.com>, <bmasney@redhat.com>,
        <andrey.konovalov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>, <ncai@quicinc.com>,
        <jsuraj@qti.qualcomm.com>, <hisunil@quicinc.com>,
        <echanude@redhat.com>
References: <20230411200409.455355-1-ahalaney@redhat.com>
 <20230411200409.455355-13-ahalaney@redhat.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230411200409.455355-13-ahalaney@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RE5nWDM1MDF3Z0hyUDNFYkcxc0hidDlnQ0VrZTZxSFEyYVJGMkJ2bE5DRmtX?=
 =?utf-8?B?TnhhNlhDYW1waEdmUlNwWGcvMERXMUlOR0U1KzZrZ2VlcVZubWk2U280Tzk3?=
 =?utf-8?B?SndrVUtkckpxeTMzdzBOMFkzRmxJa2JIR1NkMVNxK1MwQjNOS29pTHNSYVRI?=
 =?utf-8?B?WGRJbVllOWorenEvTFlBK1Q2b0dPeTZKSW1FL2dnUzI5ZFFoMzNiMkd5bU41?=
 =?utf-8?B?UWJzbGdpb3hyVVUrbXQ0OGNxeDVvQ05zWjhPdXlRM3hrQWRLajhkU0VrMWQy?=
 =?utf-8?B?aWJxbzVLYWNYVkhKd1ZVbGtFMGt6VWhyVEpTR29IeUUyc2tEbmEwdnNJcllH?=
 =?utf-8?B?QkJ2ak90TUp3NVJmSFhQaU9hbXpDamlEczZ2amU0SnNPN0pERVhsMUFzVzNu?=
 =?utf-8?B?Sm8vVnpaNlVlWjFieWRUU1Y3VnhlMmdiNGxIY1o2OExVNnhURWR6bnREUjJk?=
 =?utf-8?B?V09YdkJRUmlzYXlSZU1HdjBDVW05anpiYm5JVENqZjViSW1IYlp0M2lLMWxR?=
 =?utf-8?B?c3dGOVNoOTJpYVJyUWpSaU1RTlBsSzNCakxjSVJ6MURHVkpLUUZqTFZCSjJ6?=
 =?utf-8?B?cEtIcHhNa0hoNmp1b2ZvcGJjKzFHRThuREhkNCs0Yzh4UmJHQnR5RTQ3L2Iz?=
 =?utf-8?B?eEdub0tuRnoyaStyYlAvdjdXTUdSN1R3bzk0Sy94MlZPSURyQWZHZExNdlFC?=
 =?utf-8?B?N3pScXdrN2ZsZVRybE4vcHZZRzZJa1Q5Rm83c3VYR3NBUHZOZGVha0RJVDEx?=
 =?utf-8?B?ejY2RnFMb1ZTSGR4VjdScXBFOTc3MkZlOGhkQzlrU0V2VFdIK2pTd1JKeHBG?=
 =?utf-8?B?aFI1T21kL09mYUZGTGRxZURLZ2puR3BIQnY5SnVlNm5QWFhCT1JlSzBha2Fs?=
 =?utf-8?B?UGJONnJnS2tOVzhCcFRDcUYzb2U2a1hQQ2VISmNSd2tCZW14R3NOQWplWnpy?=
 =?utf-8?B?QWhpQWJVMmk0b084eGZQQXAwdnlyYWVvMkhDVGFQOW8rbnYra2F0ZWNMSUFm?=
 =?utf-8?B?YXdjZE1DSWtpdWVpNkEzNUJYL1JyRXFZZTNtdFRBdmVDemhtNDQzRnpOSDV4?=
 =?utf-8?B?dEdQVDdwcXJJanhWekQzaCt2Nk04L1FhUWNMcjlUa0tJUkE0UHc3RWZ4RDY2?=
 =?utf-8?B?Z2VUVkUrc3FaNjVSYXhuK2Jia2o5LzRDdEswUERpUFZ4RTBYVkRIMXVOQXVW?=
 =?utf-8?B?UTIvS01HS25oSFRqa1o4aWpaWVczaUZ1UHBWeURVR1RBS0kwQ0JlNUZqMy95?=
 =?utf-8?B?cXoxRWVSQlQ1aVloNWdqWmNUV2pEZUxreFdtYzR6cWxHQ29pa05tUW1TNGVp?=
 =?utf-8?B?REdZdDg4djE5MUVxaWFPQmJGd2tKV3kxQlVUOUJBSUptdlFuTXdrZWJxZGov?=
 =?utf-8?B?Snp2WG5heldjTDdkaVV1cERtZkNHeEZ3MHZza2VRc250NzhuV3JJNGw5WGlS?=
 =?utf-8?B?NHdYMDF6ekdVNEZ2ZUJPcU9iMXV3b0hIQUVzYytCN1J4OExQNHdudmZVL1Uy?=
 =?utf-8?B?bVN0d1dxNHQzOWhoUGNNeVJmaFF6VUFacUV1UnNPUnZKOTlIK3lHZEZDSnJy?=
 =?utf-8?B?ZGhsOWNJdXZ1UGJkR3hDZHJtbWs5YTFKbGhVTExLVU5rOHNkQ2tyV2U2Snor?=
 =?utf-8?B?RFJZemEyNmNLMXBvSHRKYW9oWHJxODVPR0FSRlc5eHRBRXVXRUtEejd1SWMz?=
 =?utf-8?B?M09hc1RMWE1LWHdWWmo5R00weTJLdzRuOGY3REorTW1xc1dES21NTDZ4a0hL?=
 =?utf-8?B?S3FMYlBXL29rWnAycjAzTGEvREFmVlZHV1RPNHd4enhVMG9kd2dwanJ1cWIv?=
 =?utf-8?B?ekpOV3NTKzVKQmxVcDk3Nkx1TTFlZFpIWkIzREk1dTFobWZVYVdra245MFZC?=
 =?utf-8?B?ZTU2OGN2S0RDczRqUUs3UGRDa3VGNlVLR0QvYmNXU3dwc2kxc3lVRUJoK29N?=
 =?utf-8?B?ak4razduQ2ducThqVTVpY1ZCbEgrY09uSHJoT3NzNkRzcU1DRTl1am9ZcFFH?=
 =?utf-8?B?ZFJjODVWRHNHMHpkaDhzSjV2ZHVQZlQ5K2w1RnlhVDdqQWZUbDlWSlZLWW94?=
 =?utf-8?B?eUhzTUdia1N6QTF4WTVheElzRzJpVmtmV0xyblNlM3FBbUYwMzUrU1ZjblFU?=
 =?utf-8?B?cWNpQTR0d0tIcml3YjJ5dmJNdU93d0o0UmJSUlIwMXdJb1lnekxDdUQybU55?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a90b0d10-fe43-4bd7-8e3d-08db3ae73072
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 23:48:03.2083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DKtCKd6NyqG/NIqYEgYeUCu2EFbuGHV4hhX2kcMseTIoSSN0LThsrUUdRHvLbxvD7QUAA1Ep3ntMxIOjC+6BLDZmTm+nz3EUKTOQ0wnNrKA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7194
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> Add the new programming sequence needed for EMAC3 based platforms such
> as the sc8280xp family.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

Looks good!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>