Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 02:26:21 +0200
From:   Cyril Brulebois <kibi@debian.org>
To:     Jim Quinlan <jim2101024@gmail.com>
Cc:     linux-pci@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Phil Elwell <phil@raspberrypi.com>,
        bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com,
        Florian Fainelli <f.fainelli@gmail.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] PCI: brcmstb: Set PCIe transaction completion
 timeout
Message-ID: <20230412002621.nuxkiflumz4vbang@mraw.org>
Organization: Debian
References: <20230411165919.23955-1-jim2101024@gmail.com>
 <20230411165919.23955-4-jim2101024@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zhilsb22jfyf7zcz"
Content-Disposition: inline
In-Reply-To: <20230411165919.23955-4-jim2101024@gmail.com>
Precedence: bulk


--zhilsb22jfyf7zcz
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jim,

Jim Quinlan <jim2101024@gmail.com> (2023-04-11):
> Since the STB PCIe HW will cause a CPU abort on a PCIe transaction
> completion timeout abort, we might as well extend the default timeout
> limit.  Further, different devices and systems may requires a larger or
> smaller amount commensurate with their L1SS exit time, so the property
> "brcm,completion-abort-us" may be used to set a custom timeout value.
   ^^^^^^^^^^^^^^^^^^^^^^^^

> +	ret =3D of_property_read_u32(pcie->np, "brcm,completion-timeout-us",
> +				   &timeout_us);
> +	if (ret && ret !=3D -EINVAL)
> +		dev_err(pcie->dev, "malformed/invalid 'brcm,completion-timeout-us'\n");

v2 renames brcm,completion-abort-msecs into brcm,completion-timeout-us
but the commit message mentions the half-way brcm,completion-abort-us
property instead.

(Also spotted =E2=80=9Cimmplementation=E2=80=9D in 2/3 but I thought I'd sp=
are everyone
an extra mail.)


Cheers,
--=20
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

--zhilsb22jfyf7zcz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmQ1+qkACgkQ/5FK8MKz
VSDR9A//SGkUb7J8cgwWLrNmjetx04cvntLjkLt8/1iwZAGeEfIbD4VoeAxedneM
ZcsuIW9DwkS9pnU/TBhyuTAMQ0F+fTX4EeunPSmE6jjLUPffDD2Z7Pqlygblq59r
+n2i17q26DP4ol6Vq7yKMmhPjldfI9SaImL+DzOsMITGG/D46vTmXJh8cbKEEpAw
yZ163qBDJYnz5WI6fNbV/fU0NfIi2DiNHSDE1wWG5yEkAThchGGDXFabJIXuVWT4
mQfflVQtniOLIohENmJQNRdG+AdveTBTXZ3N6vriFJR0E64rUcno89PKRSdLuyv9
z7ihC+3AWGhZoIszb3R21bqU5kKJH/u62E9GB4BsQX/WwkGZD4bhUxExFak1ohaI
HmHtG9Hwr8+ddUkQuNAT2MLyI0mav98fDkL5KN7gnmlRzCnlFp2BiJCdmdmvt6HB
3BjRhfZSDNtv+vJIOUqYUUIS3DQ91Bj2e7TL9FuO99MDTzFKKjJ03A0A5xJxg2Sj
qqegAd9kXWZuYD2OGJuVGFGEpt10ff0+Kpd2dHUfWXwjOkucMEJYi5pUR6QDrs28
mLnO+llKJmf1W/3Idsci5yPNB7EjJfpMBsHspz+zzQD5EliZH5Nud98nL0jvKs4U
zUagyQ8qTk6CLy8XkqZAOizzuNvpyfIv8uROm035MjGn2HRZzDc=
=VjoP
-----END PGP SIGNATURE-----

--zhilsb22jfyf7zcz--