Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 09:13:55 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Pavan Kondeti <quic_pkondeti@quicinc.com>
CC:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>, Ye Bin <yebin10@huawei.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix test_resume failure by openning swap device
 non-exclusively
Message-ID: <ZDYF0xjpz7+b/Rmj@chenyu5-mobl1>
References: <cover.1681186310.git.yu.c.chen@intel.com>
 <20230411053050.GA4099424@hu-pkondeti-hyd.qualcomm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230411053050.GA4099424@hu-pkondeti-hyd.qualcomm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kM+zHi48tZ6xiI8soKlIOt/sSyBFAkytDTrnzh5hzMFnYv8bisM5Frr4hpuJ?=
 =?us-ascii?Q?BlSrmhac0ypD25K3o+l6G7jYmPxr51rlJtjASeFo3cHqu4CSiaKKEmObEmQr?=
 =?us-ascii?Q?8/NNuPiC5Hc66GbuX7thyUoQUzfHz54CDIzvdw8Y+la4vbkUYaiG7GmQHvHw?=
 =?us-ascii?Q?e/Lj797/KUG5X8/pTaqb7Xrx6V5fKylK6PISgA0WHdcNMpvgq42kZrTBlNK9?=
 =?us-ascii?Q?yZZMnFal0oviiaUmS+G/N03/biWG9GkoqzLfdXC8jroCz6zDPRJis1DaMoCT?=
 =?us-ascii?Q?wM5BB5sNVVhYz1GiJaA16jE1u9BbQGqer7DGB3N8MTaTgnr8fzc2VMBZlAgs?=
 =?us-ascii?Q?zPR2fpYUr93+bp/ZUowasSIGuajcJzT/9uNziCdnXFwZXxkTrt9y+axLqGV3?=
 =?us-ascii?Q?Hhll7oik/sd66x6HPM8dRIn2/VvIS7TrK4atwGIKCBHnIcN5pnuJO7wT5IF7?=
 =?us-ascii?Q?FMVBhvgqwQqmMC/Xmz1+cEsCnzIInLBRUj+llUaRSIC+w5xM66hUYso7rRv1?=
 =?us-ascii?Q?Sw7opBiGCkY442zTUgL+PzgmhJm63uPXwvKmifGPAMm/S0vmQQ+oUPBSJe4F?=
 =?us-ascii?Q?YkEu8X5zimO8V5GM+mYIvfi4Ep3DTDuFP9S3NXFOt8wiQDE/J0IssN13KLWN?=
 =?us-ascii?Q?LkA4962Pb6S2WO1SPEZy09gCvMNYVlY2w99dKOJNpvj2uZsxXA7nrK2nGt25?=
 =?us-ascii?Q?SxTXz7D6sWSgIzi/RQb1ArUHwLQ+cxorS7VZRHURadb7DrYH9VwCt33lHpQT?=
 =?us-ascii?Q?rEyhFP/GR5oJ6HEeGoYSK0AeNGIGcZF/mfLRS3PGuri4bK1q4+raE5otGueR?=
 =?us-ascii?Q?KOt3lCsXF0ROUKkeE8ar7lWsOeGbvoPR5cZkMOdqQrd2eClCr7aKyu9lhlmZ?=
 =?us-ascii?Q?MvTWXu0rRa7rGPaGrDYJHyPGgPx8bMTCQeEpT2pWmnswtQpoEa6CNsfHgETg?=
 =?us-ascii?Q?Rl93hncP8g/t70mqBYO/5qdDUsjbDaxuXFnAP9K0M9zJFHpya02qNF68xzUU?=
 =?us-ascii?Q?wFqUEuRsEKqT1EPka3yuZZrounGTBjGO2cHmqHrN0Am4ILQD/mrd35pJW1sZ?=
 =?us-ascii?Q?W5Pifguvaf7+8iMSZQ2i4E9W7d+bD4mKO925vutVvmfHNZA0R5wBUUp/So/o?=
 =?us-ascii?Q?oDwfS9Hs3JL/qdZm8lbqC15rIpR6QfVO/dfsCuUu2lMTNK6mJp+A9TVxiYg6?=
 =?us-ascii?Q?JYBsICCLBN2BsY27qbD1/OfazvgvcJ85mOudE3H0NvNpVrAuTu4k94OP1ZWO?=
 =?us-ascii?Q?43/FiiLo2XFyDMQcRvSeseZ5kWm4g6WuiY8R59A1KocP5jaevh4Fq9E/TvBa?=
 =?us-ascii?Q?7KAGv3R4OODMH8zTiqnEmWTD6Qot8R3UQLHzsBrVQ0WuGXF77BVLTaD+xfR5?=
 =?us-ascii?Q?VxSdkVtyrafOAbiYBkdOW8eEDbur3VQbukaAXMOWiA4mBDm2/CvccHfZuA8/?=
 =?us-ascii?Q?bZLWYi2JnaNNs9g5Zx5qiemMFObHYwh4gXXfSX8SzTAJeLo5J6tswUMMAo4v?=
 =?us-ascii?Q?65OE80Um0Jlta59YFeYl0EhzssbtmUaMF+KAy4VaOKFo2BpmcKydhQEtoXaJ?=
 =?us-ascii?Q?4tV+Vw7B2YK1sRQNSYFg5BiQFAETPBCt9kiHHwKN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 187341bb-d3d8-442b-244b-08db3af33610
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6211.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 01:14:06.4619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DPbwGnDEkuVpVWLr0paDoY1kH+sbwcavToEb1wYkMvPD4zXDTdHFjDM8kNByHdSW/nXITdcBnqe75cH+UtyDlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5135
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-04-11 at 11:00:50 +0530, Pavan Kondeti wrote:
> On Tue, Apr 11, 2023 at 08:18:43PM +0800, Chen Yu wrote:
> > test_resume does not work in current kernel when using swapfile for hibernation.
> > This is because the swap device should be openned non-exclusively in test_resume mode.
> > 
> > Patch 1 is a preparation for patch 2 and it turns snapshot_test into a global variable.
> > Patch 2 opens swap device non-exclusively for test_resume mode, and exclusively for manual
> > hibernation resume.
> > 
> > Change since v1:
> > Turn snapshot_test into global variable and do not introduce parameters for swsusp_check()
> > nor load_image_and_restore().
> > 
> > 
> > Chen Yu (2):
> >   PM: hibernate: Turn snapshot_test into global variable
> >   PM: hibernate: Do not get block device exclusively in test_resume mode
> > 
> >  kernel/power/hibernate.c | 12 +++++++++---
> >  kernel/power/power.h     |  1 +
> >  kernel/power/swap.c      |  5 +++--
> >  3 files changed, 13 insertions(+), 5 deletions(-)
> > 
> Looks good to me.
> 
> I have verified test_resume on QEMU arm64 and it worked fine with
> these two patches included.
>
Thanks, can I add your Tested-by tag?

thanks,
Chenyu 
> Thanks,
> Pavan