Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, kernel-janitors@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        John Garry <john.g.garry@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] scsi: scsi_debug: Fix missing error code in
 scsi_debug_init()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com>
        (Harshit Mogalapalli's message of "Thu, 6 Apr 2023 00:46:07 -0700")
Organization: Oracle Corporation
Message-ID: <yq1a5zdoq93.fsf@ca-mkp.ca.oracle.com>
References: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com>
Date:   Tue, 11 Apr 2023 21:15:55 -0400
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wTWYbB87yBv9iE6Pzqh2RJ5FTOvElYefw77xJP/V0SOTXRkS89S00w0gHy6W?=
 =?us-ascii?Q?SSFrEAupPAV09DDUZI2R97cjktIXydtXN8t+fBCF6VXWZYmcSw4VraN+kFiQ?=
 =?us-ascii?Q?5dowHDzuBjKWk/k9eEgUDoNFc44j+mMv4bV7mKekfmJ1s825gLkZ2SsDQzdH?=
 =?us-ascii?Q?pSl1OTn0QDHO5xJiw7UH8TDiYY5UlY8uWMsd3jARYaFV4+8lsDq3ocAP+O2I?=
 =?us-ascii?Q?mU0Ce6b3OTrVn1WIH1ifzlSNKHIP0ReRTZoaAkXNCr8JrwsDy5V4rjE1voUh?=
 =?us-ascii?Q?N4yw4htbE6hdnAaGk9gwOv11eh57hlCkLx1eNuLRowqbVPWTp0CB/yMx2zAa?=
 =?us-ascii?Q?/KF6gAnRcaOe3TApgBix4IrWYD+0Q4wIVOb6qdgrZ3KrizoQNDi8jDSSLKOM?=
 =?us-ascii?Q?n+1PHPVCPdwT7fbFYqASVqtXkZo92+iRtnrFMzC1Y8FMPzUJGpCJWwLlOk94?=
 =?us-ascii?Q?pD0l/pypMLn+n97CxQGtZlSsYcinIQ4AqEOvPlgrqXYtSn8EBNlsvGX4ZLrv?=
 =?us-ascii?Q?qjS3Yc/WoC3acY4O5iZoJKyuTESw5Qk3lKSnt5LVHh+gZnvzCTuA7FzPEbNE?=
 =?us-ascii?Q?4BkTA0Wl+2R6zWER0xpSPUqSASlasDzV+WnDbsNz4viKJVFZb1zsEeoaecHP?=
 =?us-ascii?Q?q7MlSNL9mnJGGRddZvIRHMRV6T2trJUbXqVrHJBnmryZZBxJQnMJPEvCYaZ0?=
 =?us-ascii?Q?JfTkgJwZ4FAOTTs5eO1MLTIJWmUDkdiz+WMs158HpzJAUbc2uTKXPhv46ylR?=
 =?us-ascii?Q?TLGC0htMkzDg3eKrkW1s+jHfKU9VCb1WsGSrM6FkAt1xN0JLTinMoakziKWH?=
 =?us-ascii?Q?zzB4ciKtCypIBVLY+tHr1Q0GOcHaaxOGcRyGSunAMst495rSS0xEFOZCQ3VR?=
 =?us-ascii?Q?2Pr7gGc1keq56M3bhM8TGWM+iTp9+E99S3BLUcN/OFi/+Yxia9Zmy8XYew81?=
 =?us-ascii?Q?/vrV6sG4v/97U5GkRrCT+UR4gK5qg1MXdS2N099hhVGCZNCHC7ZKxI7p2mf0?=
 =?us-ascii?Q?V3tlTyVq+SePU9n6k6/pIp6Pn0bNqiyL2iNVVozR2fJn5Okqi9P1aSju7WKd?=
 =?us-ascii?Q?4/NE1i3eSW8m0IZbfx2y0lG/DKd1lmlUB4lKoINxAXgBRGrLWJZoIMZiKZN+?=
 =?us-ascii?Q?uNZoPy5ERkLcQyyaW5M3mqVE0+HeKHjNBPXAbFea7kXNVVk04ZjDt4SgwT1J?=
 =?us-ascii?Q?YstVnfUt7Y4XlvcgaBG365nj/6tScCxEoloVzqko9XMBeLnoTrHaMrwXnO7r?=
 =?us-ascii?Q?KpawA72VSnZbEdHsGXAE5fRW5Sw6mZZXZ1KkDmzcZS08Hvb6fzItBmEmEzZV?=
 =?us-ascii?Q?KhZn1zMvbJh7Dg0AI2PiGuYcvUuw1b6LXl20TOEz16PVgiljGQU2aWsfVY8a?=
 =?us-ascii?Q?dtDH2AUFXvZcVd44ncf9wFWO1+8G9cfsvo0zcHZXGjXy0x2BxnQ5Au/xDRCs?=
 =?us-ascii?Q?8vEx6+yZEn7LLQauPveBBXJKUYwn9PSwc4Td5kOenj4tRDFn5Txe9BrGTpA8?=
 =?us-ascii?Q?UYeqVa4d6qS65nqh5sQ9XLwY05eBX+IGrLwLJ0JNdRDHrVrpG0IObpp107/0?=
 =?us-ascii?Q?qu5Eque6ddVE6dYpAdUT5qPg3CyiX1f3vOhQS5p5ZFrashp3HDFKrL4Xeq+Z?=
 =?us-ascii?Q?Hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lrHG5/y3qzxUn9AY3ZWg3pX+NIBvkmizCfyaXKi1pQcBvCOkuIHB1Y0ey1f7dhrxo8P7jXrPvrFI2zebY+Xg4sS+HMQ4QQ6Wh+zweXOs8ere/cPBwXcxEysewzqGvoDY1pqPCcNU25kxOxoucqAcLARIYoHAdJT7eCRFSswr6yQrPylU3JCcKBUqoXx8QHM4cYHcqIFvJkvDqm/sLGI+diOQeW4JXbFdJCW1qghlFq5kjpw/6KqHRdbWFRkLC4e2XK0fPb0mUFrIuUEBNBLEao6kO8P2NeEuviYIadAvG6N3HPuU/a7jnZ2+msFUtvxz9bq80SCkthpnxcIyo6h999B4KhHR6wRSMXu2KKoH5Rf5kycF1YpAlUGGxIbYKVWfu0JOlDPU0UquE4/PfPO9ykwCAybyiDc31FkQnjUKD9NQgvNYChmXvSEUcPvBMB16zt9ZfwpPzFAtPOm96ujC0KE8MEu/86FPBFfOEVARe9HxUr8gKzM5wr9soocJpdIztS57DIWHDAilDBjq4O1xkiVXdOhzYiREQ8XwDg38IfMAT3cge0dt2/c32fzln5ZdwbYBfB4EQB4RMrFFeYkVkL15/qcSSnNnIMPuwcMBELKy6qKGbdtn/Q5X2gkwP+5g7aKCEc23x8cmP3jO33Jb5zkQqk8+j/TYxRh5164fAy6zq/ayhJzBFez8gOUsOXWJo8SRVpOqxQbsElXFd/fdo8ZK5bm9Wvo3HCx2qZLC5LXq4XWzwepGI9Q1ePFHrwggiN+j9piiy5Kz64ZGKJtWMVeV+IgcoGATaa+7DVssZH8Hc0TdYdXh/doEPa7IQTtO8IUo0bbW+dyNPhBg0FGPgg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af025cf6-f105-4b58-bc9d-08db3af37958
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 01:15:59.3436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mWrXAKCB0g66Qd9kVxM2IJjQJ1AgWikAuH3NzQWOhYdW+ZX9VNZDHZzFKJ3iez+o6AA466b+kfUJbP++2kuUMogPXxLvDl/PZDeqjfSU8qg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6396
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-11_16,2023-04-11_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=895
 phishscore=0 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304120009
X-Proofpoint-GUID: YCCAJs5PKNk-0VBJKRHQIWqEqgruOfA3
X-Proofpoint-ORIG-GUID: YCCAJs5PKNk-0VBJKRHQIWqEqgruOfA3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Harshit,

> Smatch reports: drivers/scsi/scsi_debug.c:6996
> 	scsi_debug_init() warn: missing error code 'ret'

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering