Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 18:49:52 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     xu xin <xu.xin.sc@gmail.com>
Cc:     bridge@lists.linux-foundation.org, davem@davemloft.net,
        edumazet@google.com, jiang.xuexin@zte.com.cn,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        pabeni@redhat.com, roopa@nvidia.com, yang.yang29@zte.com.cn,
        zhang.yunkai@zte.com.cn, xu.xin16@zte.com.cn, razor@blackwall.org
Subject: Re: [PATCH net-next] net/bridge: add drop reasons for bridge
 forwarding
Message-ID: <20230411184952.1657b8c9@kernel.org>
In-Reply-To: <20230412013310.174561-1-xu.xin16@zte.com.cn>
References: <20230407200319.72fd763f@kernel.org>
        <20230412013310.174561-1-xu.xin16@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 12 Apr 2023 09:33:10 +0800 xu xin wrote:
> >You can return the reason from this function. That's the whole point of
> >SKB_NOT_DROPPED_YET existing and being equal to 0.
> 
> If returning the reasons, then the funtion will have to be renamed because
> 'should_deliever()' is expected to return a non-zero value  when it's ok to
> deliever. I don't want to change the name here, and it's better to keep its
> name and use the pointer to store the reasons.

Sure. You have to touch all callers, anyway, you can as well adjust 
the name.