Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b966f46a5f60de629681527bb00401830118947.camel@perches.com>
Subject: Re: [RFC PATCH] checkpatch: Support __initconst combined with
 struct definition
From:   Joe Perches <joe@perches.com>
To:     Andy Shevchenko <andy@kernel.org>,
        =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>
Cc:     Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org,
        =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@rivosinc.com>
Date:   Tue, 11 Apr 2023 18:53:42 -0700
In-Reply-To: <ZDVixjH5qLoy1jTW@smile.fi.intel.com>
References: <20230301094320.15954-1-bjorn@kernel.org>
         <ZDVixjH5qLoy1jTW@smile.fi.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-04-11 at 16:38 +0300, Andy Shevchenko wrote:
> On Wed, Mar 01, 2023 at 10:43:20AM +0100, Bj?rn T?pel wrote:
> > From: Bj?rn T?pel <bjorn@rivosinc.com>
> > 
> > Checkpatch sometimes report a false positive for __initconst. E.g., for the
> > following snippet:
> > 
> >  | static const struct strspn_test {
> >  | 	const char str[16];
> >  | 	const char accept[16];
> >  | 	const char reject[16];
> >  | 	unsigned a;
> >  | 	unsigned r;
> >  | } tests[] __initconst = {
> >  | 	{ "foobar", "", "", 0, 6 },
> >  | 	{ "abba", "abc", "ABBA", 4, 4 },
> >  | 	{ "abba", "a", "b", 1, 1 },
> >  | 	{ "", "abc", "abc", 0, 0},
> >  | };
> > 
> > checkpatch would report:
> > 
> >  | ERROR: Use of __initconst requires a separate use of const
> >  | #190: FILE: ./test_string.c:190:
> >  | +	} tests[] __initconst = {
> > 
> > Improve the reporting by trying harder to find the 'const'.
> 
> Joe, what do you think about this?

I think the ctx_block_outer_rev  function doesn't handle patch
context blocks and the loop at best needs to be changed to include

	last if $rawlines[$line] =~ /^@/);.

And the loop parsing couldn't handle structs with embedded
unions or structs.

I also think that checkpatch will always have false negatives
and false positives and this might not be that useful as likely
most compilers should now be able to identify this as well.