Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa83f623-517f-9b4f-9b82-9cae4a0aba60@starfivetech.com>
Date:   Wed, 12 Apr 2023 10:36:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v1 2/3] cpufreq: dt-platdev: Add JH7110 SOC to the
 allowlist
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
CC:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        "Rob Herring" <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor@kernel.org>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Shengyu Qu <wiagn233@outlook.com>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>
References: <20230411083257.16155-1-mason.huo@starfivetech.com>
 <20230411083257.16155-3-mason.huo@starfivetech.com>
 <20230411-rewire-outlook-a5fb631fb635@wendy>
From:   Mason Huo <mason.huo@starfivetech.com>
In-Reply-To: <20230411-rewire-outlook-a5fb631fb635@wendy>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/11 17:20, Conor Dooley wrote:
> On Tue, Apr 11, 2023 at 04:32:56PM +0800, Mason Huo wrote:
>> Add the compatible strings for supporting the generic
>> cpufreq driver on the StarFive JH7110 SoC.
>> 
>> Signed-off-by: Mason Huo <mason.huo@starfivetech.com>
>> ---
>>  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index e85703651098..a1ac955aa7e2 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -92,6 +92,7 @@ static const struct of_device_id allowlist[] __initconst = {
>>  
>>  	{ .compatible = "xlnx,zynq-7000", },
>>  	{ .compatible = "xlnx,zynqmp", },
>> +	{ .compatible = "starfive,jh7110", },
> 
> This struct looks to be in alphabetical order with a blank line between
> vendors.

Right. Should place it behind "st-ericsson".

Thanks
Mason