Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0f27ed2-9144-ff91-fe11-92e19eaf6013@starfivetech.com>
Date:   Wed, 12 Apr 2023 10:36:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v1 1/3] riscv: dts: starfive: Enable axp15060 pmic for
 cpufreq
Content-Language: en-US
To:     Shengyu Qu <wiagn233@outlook.com>,
        Conor Dooley <conor.dooley@microchip.com>
CC:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        "Rob Herring" <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor@kernel.org>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>
References: <20230411083257.16155-1-mason.huo@starfivetech.com>
 <20230411083257.16155-2-mason.huo@starfivetech.com>
 <20230411-chimp-unvarying-142394732ff5@wendy>
 <TY3P286MB261181FB1FDAF6B14CDB266B989A9@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
From:   Mason Huo <mason.huo@starfivetech.com>
In-Reply-To: <TY3P286MB261181FB1FDAF6B14CDB266B989A9@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk


On 2023/4/11 22:49, Shengyu Qu wrote:
>> On Tue, Apr 11, 2023 at 04:32:55PM +0800, Mason Huo wrote:
>>> The VisionFive 2 board has an embedded pmic axp15060,
>>> which supports the cpu DVFS through the dcdc2 regulator.
>>> This patch enables axp15060 pmic and configs the dcdc2.
>>>
>>> Signed-off-by: Mason Huo <mason.huo@starfivetech.com>
>>> ---
>>>   .../starfive/jh7110-starfive-visionfive-2.dtsi    | 15 +++++++++++++++
>>>   1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>>> index 2a6d81609284..df582bddae4b 100644
>>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>>> @@ -114,6 +114,21 @@ &i2c5 {
>>>       pinctrl-names = "default";
>>>       pinctrl-0 = <&i2c5_pins>;
>>>       status = "okay";
>>> +
>>> +    pmic: axp15060_reg@36 {
>> No underscores in node names please & "pmic" is the generic node name
>> for pmics.
>>
>> Cheers,
>> Conor.
>>
>>> +        compatible = "x-powers,axp15060";
>>> +        reg = <0x36>;
>>> +
>>> +        regulators {
>>> +            reg_dcdc2: dcdc2 {
> 
> reg_dcdc2 seems not a good name, too generic for identification. In most
> 
> cases, it's same as regulator-name but using "_" rather than "-".
> 
Hi Shengyu,

Thanks for your review.
Will change to "vdd_cpu".

>>> +                regulator-boot-on;
> 
> It should not be used,  in Documentation/devicetree/bindings/regulator
> 
> /regulator.yaml, it is described as follows:
> 
> "This property is intended to only be used for regulators where software
> 
> cannot read the state of the regulator."
> 
> In this case, regulator state is completely able to be read by driver.
> 
> Best regards,
> 
> Shengyu
>Will remove it.

Thanks
Mason