Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp404490rwl; Tue, 11 Apr 2023 21:08:31 -0700 (PDT) X-Google-Smtp-Source: AKy350YgaXTY7bQcdXTHabmm7uCtn75opBHhNJML3hwRsxabG3hzs9qJRtG4iLnMYW/id+ZQLSvF X-Received: by 2002:a50:fb86:0:b0:504:aaba:9b0c with SMTP id e6-20020a50fb86000000b00504aaba9b0cmr4071437edq.31.1681272511354; Tue, 11 Apr 2023 21:08:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681272511; cv=none; d=google.com; s=arc-20160816; b=xkgcFfIJyDI+cB4HCJrJVK9Oi7CVIeQEd5BOHlsejqqW/tWbQivMKKdhjcojTbkwSE 3NaJgieSnROrNy2E++FcAeW6GLksNMTMJ17T2jctZeTMsNpKgUchVKxf1M/z0vLa0G4U tJqukZv591H1uDXYNMKgNQlasY22ylWT+dj6qz5CPBS5PWU9BUK/Xt/ZcKJZXC7a83jj w+6EyjH1Et42XDx+zYxk6blAmYOY0sFqKfrmLtcJdZviKyM+TmSSW6uzfzqlroK4FeRD m8KFK3QChom0Lh7+UKik4TJEs+KTovP0z3ENr5N2T3WgEn9Qpi+my/nZbh8mdHUYBgGv bjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jaf8TVcaCoY+gXRI/VJ8dcjLvYvyn0Wf6eDT01i5qTU=; b=kXK8EEpZXYN3/P4YXBjJ/kCOTbfAzX709vKT4FGJCBmtSG5GyakDbb4SIq9vB9Nvk2 LV5ui1CWrVjxtRzxRY1k4a/DSMSWU4rBr6NYK7jLM2zsZZswixU7tgM02JGVOVvW5s/j Bw3/5+24riONs3LYaP5QuZn9E0piEbJKhOZII9OMPvCjzIe1lQo1qNMdkJrzABTHIUTZ SnK+YY6pI8SewTeFJxe6BkE+/2sg1I7mYfAOI8Tt+ldb4soLcOeCoxliD5ikh8hmUomb htgW3ip610A8zRycDLlaobbaLsXJPFArKwm2YWkryduBUb5rm/xl4NWHgyuJAb95edyy spqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="gV/Q8PhB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020aa7c606000000b00504ef7f07cdsi1209857edq.448.2023.04.11.21.08.05; Tue, 11 Apr 2023 21:08:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="gV/Q8PhB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbjDLEF0 (ORCPT + 99 others); Wed, 12 Apr 2023 00:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjDLEFX (ORCPT ); Wed, 12 Apr 2023 00:05:23 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24DAD4EE8; Tue, 11 Apr 2023 21:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jaf8TVcaCoY+gXRI/VJ8dcjLvYvyn0Wf6eDT01i5qTU=; b=gV/Q8PhBJfKEwrm7QUc3Nj/RkV SdSL5cwKeC0Plg0b6mwejcTDoMjZarfDiNAgQplXpqYWFesGNsx9Ly1iS6lsQsOGJ+pmFjNCyYBZf iTxAWnMJJISxhizo+817ILIZ4QnD9GsCTv7+ptWdl3GhN2mkaCUshKhLgpYXIWL6hRXulCkBhdaqR xAasSAx0b9s9kawlt7zz92GU+EBueFmLjNPSh92Ny2DYBUxQ8C626EYy8rD6dI2n+LAlqcCd2bwnj qtaTHNNsdcvpr+FmnPzCRFCLdstHHWMLyCna3D7TkKLo6UwdqvD2aTrs6jMv7YKU2iQnB2ZHFHxEy KNQzlAXw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmRjM-001jmc-1R; Wed, 12 Apr 2023 04:05:12 +0000 Date: Tue, 11 Apr 2023 21:05:12 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v2 1/2] Change DEFINE_SEMAPHORE() to take a number argument Message-ID: References: <20230405203505.1343562-1-mcgrof@kernel.org> <20230405203505.1343562-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2023 at 09:36:30PM +0100, Matthew Wilcox wrote: > Or this: > > /* > * Unlike mutexes, binary semaphores do not have an owner, so up() can > * be called in a different thread from the one which called down(). > * It is also safe to call down_trylock() and up() from interrupt > * context. > */ I went with that. Thanks for helping me paint this shed! Luis