Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1681264483-5208-1-git-send-email-zhouzhouyi@gmail.com> <0e334497-fbc1-49f7-87ef-8dbf6d25d6a7@paulmck-laptop>
In-Reply-To: <0e334497-fbc1-49f7-87ef-8dbf6d25d6a7@paulmck-laptop>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Wed, 12 Apr 2023 13:09:20 +0800
Message-ID: <CAABZP2w8Dg5LrsSvMdYp36n_fhj2fF7qTM5CFnFAh1VJKN+HFA@mail.gmail.com>
Subject: Re: [PATCH] rcu/torture replace wait_event with wait_event_interruptible
To:     paulmck@kernel.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org, lance@osuosl.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 12:54=E2=80=AFPM Paul E. McKenney <paulmck@kernel.o=
rg> wrote:
>
> On Wed, Apr 12, 2023 at 09:54:43AM +0800, zhouzhouyi@gmail.com wrote:
> > From: Zhouyi Zhou <zhouzhouyi@gmail.com>
> >
> > In kfree_rcu_test, kfree_scale_shutdown will be detected as hung task
> > if kfree_loops is too big. Replace wait_event with wait_event_interrupt=
ible
> > to avoid false positive.
> >
> > Tested in the PPC VM of Open Source Lab of Oregon State University.
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > ---
> >  kernel/rcu/rcuscale.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
> > index 91fb5905a008..b37eec94957c 100644
> > --- a/kernel/rcu/rcuscale.c
> > +++ b/kernel/rcu/rcuscale.c
> > @@ -771,7 +771,7 @@ kfree_scale_cleanup(void)
> >  static int
> >  kfree_scale_shutdown(void *arg)
> >  {
> > -     wait_event(shutdown_wq,
> > +     wait_event_interruptible(shutdown_wq,
>
> Good catch!!!
>
> Would wait_event_idle() work in this case?  The _interruptible()
> variant indicates that wakeups due to things like POSIX signals is
> permitted.
Thank Paul for your guidance and encouragement!
I will perform a new round of rcu torture test, after this is done, I
will resend the modified version.

Thanks ;-)
Zhouyi
>
>                                                         Thanx, Paul
>
> >                  atomic_read(&n_kfree_scale_thread_ended) >=3D kfree_nr=
ealthreads);
> >
> >       smp_mb(); /* Wake before output. */
> > --
> > 2.34.1
> >