Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f729ae6-8b20-e77c-18f7-cbe093f8a3b9@starfivetech.com>
Date:   Wed, 12 Apr 2023 15:52:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree
 resources
Content-Language: en-US
To:     Conor Dooley <conor@kernel.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Walker Chen <walker.chen@starfivetech.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>
References: <20230411064743.273388-1-changhuang.liang@starfivetech.com>
 <20230411064743.273388-6-changhuang.liang@starfivetech.com>
 <20230411-stimuli-reapprove-4659d50e5d2e@spud>
From:   Changhuang Liang <changhuang.liang@starfivetech.com>
In-Reply-To: <20230411-stimuli-reapprove-4659d50e5d2e@spud>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/12 5:06, Conor Dooley wrote:
> On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
>> Different compatible parse device tree resources work in different ways.
> 
> Right now there is only one compatible, so this commit message needs to
> be expanded on to provide more information on your motivation.
> 

OK, will add more commit message.

>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> 
>>  static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
>>  {
[...]
>>  
>>  	match_data = of_device_get_match_data(dev);
>>  	if (!match_data)
>>  		return -EINVAL;
>>  
>> +	if (match_data->pmu_parse_dt) {
> 
> How can this be false?
> 
> Cheers,
> Conor.

Yes, it will not be false, I will delete this if condition