Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 11:10:43 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Aaron Lu <aaron.lu@intel.com>
Cc:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel@vger.kernel.org, Olivier Dion <odion@efficios.com>,
        michael.christie@oracle.com
Subject: Re: [RFC PATCH v4] sched: Fix performance regression introduced by
 mm_cid
Message-ID: <20230412091043.GC4253@hirez.programming.kicks-ass.net>
References: <20230410150150.2179062-1-mathieu.desnoyers@efficios.com>
 <20230411045225.GA3509@ziqianlu-desk2>
 <20230411131221.GA7356@ziqianlu-desk2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230411131221.GA7356@ziqianlu-desk2>
Precedence: bulk

On Tue, Apr 11, 2023 at 09:12:21PM +0800, Aaron Lu wrote:

> Forget about this "v4 is better than v2 and v3" part, my later test
> showed the contention can also rise to around 18% for v4.

So while I can reproduce the initial regression on a HSW-EX system
(4*18*2) and get lovely things like:

  34.47%--schedule_hrtimeout_range_clock
          schedule
          |
          --34.42%--__schedule
                    |
                    |--31.86%--_raw_spin_lock
                    |          |
                    |           --31.65%--native_queued_spin_lock_slowpath
	            |
                    --0.72%--dequeue_task_fair
                             |
                             --0.60%--dequeue_entity

On a --threads=144 run; it is completely gone when I use v4:

  6.92%--__schedule
         |
         |--2.16%--dequeue_task_fair
         |          |
         |           --1.69%--dequeue_entity
         |                     |
         |                     |--0.61%--update_load_avg
         |                     |
         |                      --0.54%--update_curr
         |
         |--1.30%--pick_next_task_fair
         |          |
         |           --0.54%--set_next_entity
         |
         |--0.77%--psi_task_switch
         |
         --0.69%--switch_mm_irqs_off


:-(