Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a937f0c71497b41dc6b7ceb30dc6fdbbed856714.camel@ew.tq-group.com>
Subject: Re: [PATCH] i2c: ocores: generate stop condition after timeout in
 polling mode
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Peter Korsgaard <peter@korsgaard.com>, Andrew Lunn <andrew@lunn.ch>
Cc:     Federico Vaga <federico.vaga@cern.ch>,
        Wolfram Sang <wsa@kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux@ew.tq-group.com" <linux@ew.tq-group.com>
Date:   Wed, 12 Apr 2023 11:49:32 +0200
In-Reply-To: <20230220161628.463620-1-matthias.schiffer@ew.tq-group.com>
References: <20230220161628.463620-1-matthias.schiffer@ew.tq-group.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-02-20 at 16:17 +0000, Matthias Schiffer wrote:
> From: Gregor Herburger <gregor.herburger@tq-group.com>
>=20
> In polling mode, no stop condition is generated after a timeout. This
> causes SCL to remain low and thereby block the bus. If this happens
> during a transfer it can cause slaves to misinterpret the subsequent
> transfer and return wrong values.
>=20
> To solve this, pass the ETIMEDOUT error up from ocores_process_polling()
> instead of setting STATE_ERROR directly. The caller is adjusted to call
> ocores_process_timeout() on error both in polling and in IRQ mode, which
> will set STATE_ERROR and generate a stop condition.
>=20
> Fixes: 69c8c0c0efa8 ("i2c: ocores: add polling interface")
> Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>


Any chance we can get someone to have a look at this patch?

Regards,
Matthias


> ---
>  drivers/i2c/busses/i2c-ocores.c | 28 +++++++++++++++-------------
>  1 file changed, 15 insertions(+), 13 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-oco=
res.c
> index a0af027db04c1..28bcda3f7040a 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -342,18 +342,18 @@ static int ocores_poll_wait(struct ocores_i2c *i2c)
>   * ocores_isr(), we just add our polling code around it.
>   *
>   * It can run in atomic context
> + *
> + * Return: 0 on success, -ETIMEDOUT on timeout
>   */
> -static void ocores_process_polling(struct ocores_i2c *i2c)
> +static int ocores_process_polling(struct ocores_i2c *i2c)
>  {
>  	while (1) {
>  		irqreturn_t ret;
>  		int err;
> =20
>  		err =3D ocores_poll_wait(i2c);
> -		if (err) {
> -			i2c->state =3D STATE_ERROR;
> -			break; /* timeout */
> -		}
> +		if (err)
> +			return err;
> =20
>  		ret =3D ocores_isr(-1, i2c);
>  		if (ret =3D=3D IRQ_NONE)
> @@ -364,6 +364,8 @@ static void ocores_process_polling(struct ocores_i2c =
*i2c)
>  					break;
>  		}
>  	}
> +
> +	return 0;
>  }
> =20
>  static int ocores_xfer_core(struct ocores_i2c *i2c,
> @@ -387,16 +389,16 @@ static int ocores_xfer_core(struct ocores_i2c *i2c,
>  	oc_setreg(i2c, OCI2C_DATA, i2c_8bit_addr_from_msg(i2c->msg));
>  	oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_START);
> =20
> -	if (polling) {
> -		ocores_process_polling(i2c);
> -	} else {
> +	if (polling)
> +		ret =3D ocores_process_polling(i2c);
> +	else
>  		ret =3D wait_event_timeout(i2c->wait,
>  					 (i2c->state =3D=3D STATE_ERROR) ||
> -					 (i2c->state =3D=3D STATE_DONE), HZ);
> -		if (ret =3D=3D 0) {
> -			ocores_process_timeout(i2c);
> -			return -ETIMEDOUT;
> -		}
> +					 (i2c->state =3D=3D STATE_DONE), HZ) ?
> +						0 : -ETIMEDOUT;
> +	if (ret) {
> +		ocores_process_timeout(i2c);
> +		return ret;
>  	}
> =20
>  	return (i2c->state =3D=3D STATE_DONE) ? num : -EIO;

--=20
TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ=
any
Amtsgericht M=C3=BCnchen, HRB 105018
Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch=
neider
http://www.tq-group.com/