Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 11:04:07 +0100
From:   Lee Jones <lee@kernel.org>
To:     "Sahin, Okan" <Okan.Sahin@analog.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v6 5/5]  mfd: max77541: Add ADI MAX77541/MAX77540 PMIC
 Support
Message-ID: <20230412100407.GA8371@google.com>
References: <20230307112835.81886-6-okan.sahin@analog.com>
 <20230315175223.GI9667@google.com>
 <20230315175257.GJ9667@google.com>
 <MN2PR03MB5168249900206433A082875EE7889@MN2PR03MB5168.namprd03.prod.outlook.com>
 <20230329143615.GS2673958@google.com>
 <MN2PR03MB51685B1F84AA679FB604E738E7929@MN2PR03MB5168.namprd03.prod.outlook.com>
 <20230403140950.GF548901@google.com>
 <ZC0zA1bVsrg0XEld@smile.fi.intel.com>
 <20230405133938.GD8371@google.com>
 <MN2PR03MB51681CCFD911F63CE32E914AE7949@MN2PR03MB5168.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <MN2PR03MB51681CCFD911F63CE32E914AE7949@MN2PR03MB5168.namprd03.prod.outlook.com>
Precedence: bulk

On Sun, 09 Apr 2023, Sahin, Okan wrote:

> >On Wed, 05 Apr 2023, Andy Shevchenko wrote:
> >
> >> On Mon, Apr 03, 2023 at 03:09:50PM +0100, Lee Jones wrote:
> >> > On Mon, 03 Apr 2023, Sahin, Okan wrote:
> >>
> >> ...
> >>
> >>
> >> > > In fact, one of the maintainers suggested assigning chip_info to data
> >> > > instead of enumeration. Then I added chip_info and put devices into
> >> > > sub-structure above. I will replace chip_info with id structure in max77541
> >> > > device structure, right? I will use enumeration for data as I will assign
> >> > > it to id, and distinguish different devices.
> >> >
> >> > Yes, that's correct.  Please remove chip_info altogether.
> >>
> >> Then it will provoke casting in the OF ID table which I believe is not what
> >> we want. I would agree on your first suggestion to have a plain number in I²C
> >> ID table, but I'm against it in OF and/or ACPI ID table.
> >
> >And I'm against passing MFD information through the OF/ACPI APIs.
> >
> >You can put through raw platform data or a device descriptor.
> >
> >Ref: git grep -A5 "struct of_device_id.*{" -- drivers/mfd
> >
> >--
> >Lee Jones [李琼斯]
>
> Hi Lee,
>
> Right now, as you suggested I rewrote code like below
> For of_device_id,
> 	. data = (void *)MAX77540,
> 	.data = (void *)MAX77541,
> For i2c_device_id,
> 	.data  = MAX77540,
> 	.data = MAX77541
> I also rewrote other part as chip_info is excluded. I want to be sure before
> sending new patch.
>
> Does it seem correct?

This is one suitable method, yes.

--
Lee Jones [李琼斯]