Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp719069rwl; Wed, 12 Apr 2023 03:10:33 -0700 (PDT) X-Google-Smtp-Source: AKy350ZC5L2BRC82gSvP5W0K8btQTBg9nuDYHIDVPoLNECAwW5nfAteRUzDr1MyhauCvk9xwohlu X-Received: by 2002:a17:906:9708:b0:94a:71f2:c3a0 with SMTP id k8-20020a170906970800b0094a71f2c3a0mr1755215ejx.54.1681294233677; Wed, 12 Apr 2023 03:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681294233; cv=none; d=google.com; s=arc-20160816; b=Lw3HNqaRa0jn93DUP4oZbuV9OdJ8jml4UmK6wuIdnJxxGsaBRLkolCxBZ35ZspmbzK 3t3DE2j0S7sjowQAMfv35YgOZ9picQQImZDr3G1cZJbuQvdCOyFuamD4gqN9ZEB/eltW wxJfxOhOIsipj1l7DIEjT1qufXiuwWbxO/LYpzQcbw9uMjnxPk6QDJp5byuSFxoJTTMO 4rMJjaWks4tIPti/PEydMtrmnDM7iuAtSeoB2GWSeW54QOoW45TlJMYSLZj6KMNTJzjw LQ8sv5th0MVvCw9zRPev3hChIr8ctrdTiNU0da9MIDhR7ThJFXyBUS0MVhOsU6/YT8fS wFzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=b1F2phn2tQu16aghuCvYNcmIrDhqOf1JzbhQMt5spfs=; b=fJptrIdBzjq1L7K5WuJphpGs9fOGpnRIIBLKfl1woygxGyvw76K4O5ZmJ7gCx1Gz62 Xe0s0BdU6M6XL3TxktobXFGHKAFc2L0GvdeLSzAIYbF/7yavXrwqEuFnTDecrh4Xz5OY l8KTeP6TNoNNVbo5/77Yo/i91jftF+WGO8IKYvV5N9FL8h4GNvNl1tUt5iET0VuhWuZs izBjRQTDhFM+Aa40MdZjpHXWyV72I5+8yr8TRHFfuwWz2EPWHu9aMnpzs5l2Z4xnNZp3 ccHZFjhgjifGD0YZPoKRZH6OJPmzYw57mDCYLdL5vErBawricZRbEgxbBm0coWyP3dW/ IJTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020aa7dd11000000b005027766cac8si14649765edv.631.2023.04.12.03.10.09; Wed, 12 Apr 2023 03:10:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbjDLKHQ convert rfc822-to-8bit (ORCPT + 99 others); Wed, 12 Apr 2023 06:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjDLKHL (ORCPT ); Wed, 12 Apr 2023 06:07:11 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7925D9000 for ; Wed, 12 Apr 2023 03:06:45 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-11-OIVFlk1zNIulZSxCxWqPCg-1; Wed, 12 Apr 2023 11:06:42 +0100 X-MC-Unique: OIVFlk1zNIulZSxCxWqPCg-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 12 Apr 2023 11:06:39 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Wed, 12 Apr 2023 11:06:39 +0100 From: David Laight To: 'Arseniy Krasnov' , Liang Yang , Miquel Raynal , "Richard Weinberger" , Vignesh Raghavendra , "Neil Armstrong" , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan CC: "oxffffaa@gmail.com" , "kernel@sberdevices.ru" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define Thread-Topic: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define Thread-Index: AQHZbQcFy/8yOpNpAUyIp49WWIi1Cq8ncmZA Date: Wed, 12 Apr 2023 10:06:39 +0000 Message-ID: <2f89000bdbbb4e2bb7f1dd96c1b498f9@AcuMS.aculab.com> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-3-AVKrasnov@sberdevices.ru> In-Reply-To: <20230412061700.1492474-3-AVKrasnov@sberdevices.ru> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,PDS_BAD_THREAD_QP_64, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arseniy Krasnov > Sent: 12 April 2023 07:17 > Subject: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define > ... > len = mtd->writesize + mtd->oobsize; > - cmd = (len & GENMASK(13, 0)) | scrambler | DMA_DIR(dir); > + cmd = (len & NFC_CMD_RAW_LEN) | scrambler | DMA_DIR(dir); > writel(cmd, nfc->reg_base + NFC_REG_CMD); What is the point of the mask? If the length is too big it just generates a different 'hard to debug' error. If the length can't be too bit there is no point masking it. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)