Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 15:37:04 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Bard Liao <yung-chuan.liao@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        pierre-louis.bossart@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH] soundwire: intel_auxdevice: improve pm_prepare step
Message-ID: <ZDaCyFdzlPmoi6qK@matsya>
References: <20230323025228.1537107-1-yung-chuan.liao@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230323025228.1537107-1-yung-chuan.liao@linux.intel.com>
Precedence: bulk

On 23-03-23, 10:52, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> In the case where multiple peripherals are attached on the same link,
> it's possible that they are in different pm_runtime states.
> 
> The device_for_each_child() loop to resume all devices before a system
> suspend would not work if one peripheral was active and others
> suspended. pm_runtime_resume() returns 1 in the former case, which is
> taken as a error. As a result, a pm_runtime suspended device might be
> skipped if the first device was active.
> 
> This patch changes the behavior of the helper function to only return
> zero or a negative error. A Fixes tag is not provided since there are
> no existing configurations on Intel platforms with different types of
> devices on the same link. Amplifiers may be used on the same link, but
> they are used by the same dailink so their pm_runtime state is always
> matching. This assumption may not be true in the future, so we should
> improve the behavior and align with AMD.

Applied, thanks

-- 
~Vinod