Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <949fc214-3216-c012-0ddd-b6e1745c35ae@leemhuis.info>
Date:   Wed, 12 Apr 2023 12:47:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] pinctrl: amd: Disable and mask interrupts on resume
Content-Language: en-US, de-DE
To:     Linus Walleij <linus.walleij@linaro.org>,
        =?UTF-8?Q?Kornel_Dul=c4=99ba?= <korneld@chromium.org>
Cc:     Linux regressions mailing list <regressions@lists.linux.dev>,
        gregkh@linuxfoundation.org,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        upstream@semihalf.com, rad@semihalf.com, mattedavis@google.com,
        stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
        "Gong, Richard" <richard.gong@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230320093259.845178-1-korneld@chromium.org>
 <d1d39179-33a0-d35b-7593-e0a02aa3b10a@amd.com>
 <ed840be8-b27b-191e-4122-72f62d8f1b7b@amd.com>
 <37178398-497c-900b-361a-34b1b77517aa@leemhuis.info>
 <CAD=NsqzFiQBxtVDmCiJ24HD0YZiwZ4PQkojHHic775EKfeuiaQ@mail.gmail.com>
 <36c7638f-964b-bee6-b44b-c8406e71dfec@leemhuis.info>
 <CAD=Nsqx2Gy08HHzjRoWxS7u559hUgi_GGRis0UDFxrUqLYjTfg@mail.gmail.com>
 <CACRpkdYoALVKFPoxxac=c9x3vRhYge+VAUSqKdkqSvgvS+PiXw@mail.gmail.com>
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
In-Reply-To: <CACRpkdYoALVKFPoxxac=c9x3vRhYge+VAUSqKdkqSvgvS+PiXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11.04.23 22:44, Linus Walleij wrote:
> On Tue, Apr 11, 2023 at 3:35 PM Kornel Dulęba <korneld@chromium.org> wrote:
>> On Tue, Apr 11, 2023 at 3:29 PM Linux regression tracking (Thorsten
>> Leemhuis) <regressions@leemhuis.info> wrote:
> 
>>> Linusw, what's your preferred course to realize this revert quickly?
>>>
>>>  * someone (Kornel?) sends a revert with a commit msg for review, which
>>> you then apply and pass on to the other Linus?
>>>
>>>  * someone (Kornel?) sends a revert with a commit msg for review that
>>> immediately asks the other Linus to pick this up directly?
>>>
>>>  * we ask the other Linus directly to revert this (who then has to come
>>> up with a commit msg on his own)?
>>
>> Would you like me to send a reverting change?
>> I can do this right away.
> 
> Yeah that is best.
> 
>> The commit message would contain something like:
>>
>> This patch introduces a regression on Lenovo Z13, which can't wake
>> from the lid with it applied.
> 
> Looks good!
> 
> Thorsten: thanks for watching over this issue, we'll have it
> resolved pronto.

Thx for saying that, in cases like this there is always something in my
head that says "maybe the developers and maintainers would have done
everything just the same way and just as quickly, even if I hadn't made
so much annoying noise". But well, better save that sorry.

Side note: I sometimes wonder if reverts like this maybe should be send
directly to LinusT for mainlining with a ACK from the maintainer (e.g.
you in this case) to speed things up. Sure, having things in next for at
least a day (and running it through subsystem specific CI) can help
finding unexpected problems, but it delays things, too -- which
sometimes might result in a revert coming to late for a new stable
release. And that easily can mean that our users have to face known
issues for about one more week. :-/

Ciao, Thorsten

/me meanwhile wonders if Greg will still pick the revert up for the next
stable releases (currently in rc), if the revert reaches mainline before
they are released on Friday

/me will wait for the revert to hit mainline before he'll prod Greg
about it