Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd214418:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-334-g8c072af647-fm-20230330.001-g8c072af6
Mime-Version: 1.0
Message-Id: <8113942f-589f-4834-9ecf-7f611af82819@app.fastmail.com>
In-Reply-To: <20230411211651.3791304-1-git@hrdl.eu>
References: <20230411211651.3791304-1-git@hrdl.eu>
Date:   Wed, 12 Apr 2023 21:06:29 +1000
From:   Alistair <alistair@alistair23.me>
To:     hrdl <git@hrdl.eu>, "Linus Walleij" <linus.walleij@linaro.org>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc:     linux-input@vger.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: cyttsp5 - fix sensing configuration data structure
Content-Type: text/plain
Precedence: bulk

On Wed, 12 Apr 2023, at 7:16 AM, hrdl wrote:
> Prior to this patch, the sensing configuration data was not parsed
> correctly, breaking detection of max_tch. The vendor driver includes
> this field. This change informs the driver about the correct maximum
> number of simultaneous touch inputs.
> 
> Tested on a Pine64 PineNote with a modified touch screen controller
> firmware.
> 
> Signed-off-by: hrdl <git@hrdl.eu>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

Alistair

> ---
> drivers/input/touchscreen/cyttsp5.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index 16caffa35dd9..30102cb80fac 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
> __le16 max_z;
> u8 origin_x;
> u8 origin_y;
> + u8 panel_id;
> u8 btn;
> u8 scan_mode;
> u8 max_num_of_tch_per_refresh_cycle;
> -- 
> 2.39.2
> 
>