Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/2] input: imx_sc_key: add wakeup support
Thread-Topic: [PATCH 2/2] input: imx_sc_key: add wakeup support
Thread-Index: AQHZXWmUVLJFWxBDC068h5KGnJZKqa8j7hEAgAPIhwA=
Date:   Wed, 12 Apr 2023 12:19:00 +0000
Message-ID: <DU0PR04MB94172C2BBB554E472576B2BA889B9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230323093141.4070840-1-peng.fan@oss.nxp.com>
 <20230323093141.4070840-2-peng.fan@oss.nxp.com> <ZDN00vwyCOzFrDYt@google.com>
In-Reply-To: <ZDN00vwyCOzFrDYt@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9vBqnXCpF2pc7ELcWrYTy5rdDCj81fS+OHQdfwPWzaKl5v05gvJEN7PuFY14?=
 =?us-ascii?Q?AkBjuR6GbBaxj606IP40ZirxWHIivQuogOYFuawav8IDsOWRYnAc1UedOFrp?=
 =?us-ascii?Q?IDViQFudSHUf4ZqMF5dPn5T5u8GPp+JiNGgQ0qWhGzFHFNx1IBh3GDXbbv2Y?=
 =?us-ascii?Q?LcnNDEA2bYOuGpBRM0JpBjkOu8CO5ErtxyNLYN7lFnxSPdcIeeQV6AV8ysSI?=
 =?us-ascii?Q?iy7ly9Glkk/SsFlzdZRghP52n6Hy4MNmJ9L4bLOOW3ZSCTKAZ1OiQB6TXg/A?=
 =?us-ascii?Q?isUCiSZPQD9GaUOf+ihmhAn8pS34aK15d2suWldQyn4bBzVHJ0g3GwE98rr2?=
 =?us-ascii?Q?OZgLDdABCY/0WRSbJ4qvJ8qKykzJYABaDdlFeJqa3j0jl8oJnS42TzSL0HSl?=
 =?us-ascii?Q?B3OLPJRVAEGKS2Tzwuixv3/2lZIUpjJDXXdm9s4t0kUmidlv/FJIH7SiUP8y?=
 =?us-ascii?Q?CeD1rz1e2j0r3zYUb2sNjnP3tdwRVp7sVVS9yvv+pCIQux4KlTOVt84gcBZ5?=
 =?us-ascii?Q?55f0yMHOeFgGNW9tmSQJohZ0oscuZ9WsMvBvdgkOIfecMqdlM8NhQBUmZRMB?=
 =?us-ascii?Q?z4UFQWSji5wx0bKsWOlSVghLHrq5yD/kc/W+qxJ56cHidMjlJM+rusr9H22s?=
 =?us-ascii?Q?aS23kuCNWZ+BG97ElLt+RqefOU1P0dLbKB4j7S0gnDBV5l/3tsqaftP117Ob?=
 =?us-ascii?Q?+X/363FlPIPpSp3YdLqYakx45AaW3C0eD+WdYx0RBgIpZlb2+kKmpJV5dLE/?=
 =?us-ascii?Q?/33BUXy6OvxDUN9ZoCE6mCLRW5kfAIRKNl2NJRRtFgkU49qXXVqm5pqbap4I?=
 =?us-ascii?Q?eetH74ctaIziUYrHUctUN8u3G8OONyjr2SNy+DcypCzH8tRUNDgzy9VfBCdM?=
 =?us-ascii?Q?pwqyPAnrUCxGc3qweVmiNdl8jqz7bkExlo3NctHGA2GrmgwFCNqPTUQIkGHu?=
 =?us-ascii?Q?X907tRZYnIiPsBqNgt6qTBD7vAB5IEQFrczokC2mamg/MEI7n+FphVXvYv9M?=
 =?us-ascii?Q?scFWVphomskkjg8Lv3RAJdpRmjJKz9q8zazDUvvVL1jz1swCeK9GXTeBz+iy?=
 =?us-ascii?Q?FNwSDoEx/gUKbJ83TRf862F/l6GzETn27UlX2M0tKLNmJNVJIh9Y9OdRXS4C?=
 =?us-ascii?Q?RGDCRR0CBhhsjmEH+eNKENBMkgbiPbpuMd8f24X+uZpVy5yJi4XGxvdTpmWv?=
 =?us-ascii?Q?5qwwBx88pXqEwkE4+zf4chAWxrxPNrkeuv8wmPAidzfHnOTRFDjFI0WZePnr?=
 =?us-ascii?Q?oUr6LgZpdBYdirxdDUbIKbZPyq2dhicJTGLtG4Cz02T9f3TnJMiqd+6lWvyx?=
 =?us-ascii?Q?EFetX0NXOgadILu35A/4h/lluHdevczyK+MfvQt8zSHUo58NEah/VLH77523?=
 =?us-ascii?Q?QSfFtEX8pDpEwqve2SzmJ6lpJFoFMuMB/p1Zi0JEkpahWgp/pvzIJYF6G47w?=
 =?us-ascii?Q?mTKR6hn4795OQOsN6PLqoAAUyZNmBlha/L52QFhJtxvKPRplZ5fU/DXamCKn?=
 =?us-ascii?Q?W1OFNJysq/T1osAuto8cuJsRGtxHdDGwUoBiIqMLwGiGHwfLce3zOXu8LJhs?=
 =?us-ascii?Q?jH6OTOKaIEoMpQr/sOk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c49c9ec-7edd-4843-8333-08db3b5018f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 12:19:00.4681
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7rRdP6tUrb2+pZ4uzDe48iEAwxvHqTEkoCKrcq/pKltITfavPFL/uo3qzjokghKKMA8nD6VeohDONyuAYeuRDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7677
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 2/2] input: imx_sc_key: add wakeup support
>=20
> On Thu, Mar 23, 2023 at 05:31:41PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add support for waking up from system wide suspend.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/input/keyboard/imx_sc_key.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/input/keyboard/imx_sc_key.c
> b/drivers/input/keyboard/imx_sc_key.c
> > index d18839f1f4f6..234f23cf9990 100644
> > --- a/drivers/input/keyboard/imx_sc_key.c
> > +++ b/drivers/input/keyboard/imx_sc_key.c
> > @@ -151,6 +151,8 @@ static int imx_sc_key_probe(struct
> platform_device *pdev)
> >  	priv->input =3D input;
> >  	platform_set_drvdata(pdev, priv);
> >
> > +	device_init_wakeup(&pdev->dev,
> device_property_read_bool(&pdev->dev, "wakeup-source"));
> > +
>=20
> I wonder - could we move this to the device core?

I see lots device drivers parse wakeup-source, so I also follow
That. Not sure whether could move this feature to device core,
but anyway I could give a try.

Thanks,
Peng.
>=20
> >  	error =3D imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE,
> SC_IRQ_BUTTON,
> >  					 true);
> >  	if (error) {
> > --
> > 2.37.1
> >
>=20
> Thanks.
>=20
> --
> Dmitry