Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 13:09:41 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Baili Deng <bailideng@google.com>
Cc:     Guenter Roeck <groeck@google.com>,
        David Rau <David.Rau.opensource@dm.renesas.com>,
        support.opensource@diasemi.com, lgirdwood@gmail.com,
        perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: da7219: Improve the relability of AAD IRQ process
Message-ID: <227d1f11-dea0-400a-96c9-dee568730a13@sirena.org.uk>
References: <20230410092634.4870-1-David.Rau.opensource@dm.renesas.com>
 <d9dac02a-328d-485e-9aff-158852eeb990@sirena.org.uk>
 <CABXOdTfGD_fyi+itsr9Nd834Pb6+4Ej8M9SM5AN=uhXQ1K4DiA@mail.gmail.com>
 <CADP_shKfY6-F_4+_eYv=NC9XcgVA+0H3BkCqH8D9wkqJ5SpMDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HGqq5x0t3aI77m3z"
Content-Disposition: inline
In-Reply-To: <CADP_shKfY6-F_4+_eYv=NC9XcgVA+0H3BkCqH8D9wkqJ5SpMDQ@mail.gmail.com>
Precedence: bulk


--HGqq5x0t3aI77m3z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 12, 2023 at 10:32:47AM +0800, Baili Deng wrote:
> The change in the patch done to address the issue Geunter mentioned is that
> da7219_aad_handle_gnd_switch_time() is now called before interrupts are
> enabled. To address the msleep() issue, the delay is now added as a delayed
> work of its own workqueue.

The point with the question was that this sort of stuff should be in the
commit messages.  I can't really tell what the change is supposed to do
as things stand.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

--HGqq5x0t3aI77m3z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQ2n4QACgkQJNaLcl1U
h9Anygf/ZHIBfSJdWGpYgQ5BSRZ4BRIeIzoPwlN7HkXB7lURVXdyGnp9YPjzvLa1
9wRVQOX7rhvketKQX64797qKzSplQoOKLudaRkjdWQHllB6HZpciEJ56kdHMKZoP
3u4HU4fMSIgNw5DV2lRJ47q8fjxm9pB3G51eSvFgpgPFWXs1OKzU058x5n8QYRzG
LDE6UlciSv2m+jW8Z12EPVNxRKmX6RS8C+Jy8GYFGhTU79mdIpeoAAHpYnF2eFfS
s4pEBCm0LCE1ySS/rf1Vf6s6Ayn+Gu1vavK/GaXa18MXJ08aozU8VxeIEr/vxgPN
BkMGapPp/y8XiseNNXv1m4bMF26HFA==
=n3/l
-----END PGP SIGNATURE-----

--HGqq5x0t3aI77m3z--