Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 14:24:37 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Tony Dinh <mibodhi@gmail.com>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Arnd Bergmann <arnd@arndb.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Olof Johansson <olof@lixom.net>,
        Rob Herring <robh+dt@kernel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-kernel@vger.kernel.org, soc@kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
Message-ID: <eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch>
References: <20230412025737.20280-1-mibodhi@gmail.com>
 <20230412025737.20280-3-mibodhi@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412025737.20280-3-mibodhi@gmail.com>
Precedence: bulk

> +
> +/ {
> +	model = "Thecus N2350";
> +	compatible = "marvell,armada385";

If you look at all the other armarda-385 .dts files, they all have a
board compatible. It might not be needed now, but it could be useful
in the future and allow backwards compatibility.

> +&mdio {
> +	phy0: ethernet-phy@0 {
> +		reg = <1>;
> +	};
> +};

Since you have ref = <1>, this should be ethernet-phy@1.