Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <53c2e18b-48ec-fded-e1d8-7b345dea49ba@amd.com>
Date:   Wed, 12 Apr 2023 14:22:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 0/7] drm: fdinfo memory stats
Content-Language: en-US
To:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Rob Clark <robdclark@gmail.com>,
        dri-devel@lists.freedesktop.org
Cc:     linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Christopher Healy <healych@amazon.com>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Rob Clark <robdclark@chromium.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>,
        Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>,
        Christian Gmeiner <christian.gmeiner@gmail.com>,
        "moderated list:DRM DRIVERS FOR VIVANTE GPU IP" 
        <etnaviv@lists.freedesktop.org>, Evan Quan <evan.quan@amd.com>,
        Guchun Chen <guchun.chen@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        intel-gfx@lists.freedesktop.org,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Mario Limonciello <mario.limonciello@amd.com>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <mdaenzer@redhat.com>,
        Russell King <linux+etnaviv@armlinux.org.uk>,
        Sean Paul <sean@poorly.run>,
        Shashank Sharma <shashank.sharma@amd.com>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        YiPeng Chai <YiPeng.Chai@amd.com>
References: <20230411225725.2032862-1-robdclark@gmail.com>
 <bbbbbf34-2ea5-5344-30db-f976c5198d75@amd.com>
 <98bb3388-d671-dcf3-0247-649a702b5e11@linux.intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <98bb3388-d671-dcf3-0247-649a702b5e11@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2orY1g5QUt2YUEyT2wwZ1BlM050MVpaVkNvRnZxTnJmYXk5V3JTTjZRTUJw?=
 =?utf-8?B?cnRlblB6T01EYVRRWk9RWUdOMERDUHlFWlJmVDE1Z3diWFBWN3ZiQnZBcEJX?=
 =?utf-8?B?MUFHOFNNVi85UlczWWUrNS8yWllvQy92U3NMMUl6T3Z1NlU0eG0rVjN4RzhS?=
 =?utf-8?B?cStRQ0NoVHUxcDlkeEVpVE9YblBkZ3l6SXZMTmF2NEtFbEgwNjgyY2JSRS9x?=
 =?utf-8?B?U2ZFbW1pREJQakw0Q2Q3cjhKVTZtQ2pxKzR6ekpXSVdkMlZydWluTGVQanUx?=
 =?utf-8?B?aHV5ejExeDFJajBvQlozaGVYSjIzMkNuNWpNSGloMENCYTdrUHVaZk9BQlc5?=
 =?utf-8?B?eSsySjhwZlhzMkVKb0NPeGMvRnduMjVNVkJIQjA2ZmZSVU05ZjZoVG00YkJF?=
 =?utf-8?B?Y0xwRlREQUhwamFsYUhTZmlWc0syRFRBZGhPcEhENm55NWJiWGNTbHcyME1V?=
 =?utf-8?B?OUVuN0lVYmViTTVTZ0tkMG5uK1VPU3dDbmMvcElJa1duQ2c3RW9xODM0bEph?=
 =?utf-8?B?QXNBdmNCUTFTQlpSSzJYN0FCVjlBWGxqWisyczU2a1VrczUwNTgwUE9qUzVR?=
 =?utf-8?B?Y04zV3Uxakw1ekFHVkJjclJDZ1ZaYlVTUkhFdVZyVnFnMTFHdTEycnR4RzEy?=
 =?utf-8?B?SVlCU3JzL3g1TEhMaGJuUE0zVXpEK3FZMU1LdU93SytpRWw0b05PZVhYZVc5?=
 =?utf-8?B?OWJHMVFpMmxUaG5mTUVLT0h2VlQrM2hlTzBiUytQTENnTzdlT0RpSkZpenpS?=
 =?utf-8?B?WGRVRG5nb29aV2FWa3RzSHIzbklYaEN1eUdPV2NSUWhQbXBzMVJzR1djWncx?=
 =?utf-8?B?WndIUFZYaUUwUDA0bUdTd1kreWZvMFVqQ2swZUhoRGp1dklpelMydEpidldF?=
 =?utf-8?B?ODhPUE9UVEt3MU4ySjFKNzVHOTEzcWhoMmgrdDBxREFkMXl6SDRDaFpEV3NE?=
 =?utf-8?B?WGRibXF1WGtWZnM3MTFoaHBsYU56ajRaMHdBVFRqQk5jbUhTSFVEVkdFY2pa?=
 =?utf-8?B?VVlBTW5OUkRiUmE4SnZJbTBDY1dhUE5EMG1ZL2p6U09CY09UVnl6K25YY3FV?=
 =?utf-8?B?cklZRGVGclgrVGF1bmQxQ3IxWXVEYzM3NHFKZ0NpdFQ5WjVRUmI2NnJoZ0Fa?=
 =?utf-8?B?cGIzQnIzRWdFYk1NVVNaZVVPaTgzckxXZU1FbTFVaTYrZG9Odm5FTkVvcUlN?=
 =?utf-8?B?Z2JseVN0ODV3KzFTYVRWb0lmSWo0U2xieDA4WXc0VGFsdDBhZTMvZXR6cmgz?=
 =?utf-8?B?YUVBVjRGdDdvemNwMEd3d3RaUjVZRDJSKyttRmRJdmxFRVZKMDdiWWxFcmJ2?=
 =?utf-8?B?TTgvTEs1TlpRTWh0a21ZQVpBNFNNQk5YbWw3QU1jWGRnbCs5Q2dZWHcrY3ps?=
 =?utf-8?B?R3AzMUwxbjB1S3k2NitMaUJmUUhTZlVpeWlJVlcvekI4K1loUktjU0NkdXV5?=
 =?utf-8?B?QW8rQkFOMkNuN1VibkNtN2Q4TW5YMUVoc2c3VkdtSGJncVVISkRYYnZOcEZl?=
 =?utf-8?B?bm1USDMzY0pmM09MazNWT3NKeGhzc0RrNjhLTXNIMlNGNHhLbzhZMVg2N3NR?=
 =?utf-8?B?RXhDdExEZzFYYzBvd1BYcUF5MGI0ZE5HMmUxUXMzY1NEN0dXeVNXdEpRTzEx?=
 =?utf-8?B?b1AwTFVHOURMMk5xZ3JDYWRJU2N1V0dxQVpyM08vZnNJTzYxWDZWanZTODlM?=
 =?utf-8?B?WWZvdTlSbzU2WlpRZ2k3eVNjajh1Mm82ZmVrUGhlcW5xTUZFOU5mNzcrZW9W?=
 =?utf-8?B?THpzNks1NWFMdFdTZ2Z3eXBnRFlqSFZSdk5DY2lkZUZqb1FFMEJpUnhXd3N1?=
 =?utf-8?B?dlRaZmUxd1pJdWJINUdHUmZyWS9lS3dwWTJJUVNnYTlLUmhtSkpYb2NCUjZl?=
 =?utf-8?B?ZGNsK1EzSFJTeHlONnVZQ3YweEJXUWRXTmZFU2Fxb3M5YUxMZ0hFYjRVWVBv?=
 =?utf-8?B?V3NQcVJyQjBNT3NWUERaT0tZWFN2MkFPQ0p1bG5XalRDa0xpOE9Rd1V2TlBk?=
 =?utf-8?B?cDJKaFN6SDl4WFNadTFycTRSNHJ0S3BFZXIweFhZOEFjWXNmcHBpNlI1c2NG?=
 =?utf-8?B?NmltN1l0b21CajdienBPbjY0ZThsWWpkS29jWUxXbGhYbUdiZWlOc1JSSEhx?=
 =?utf-8?B?ekhvLzZvUVU1cHczUmVGaTBIOEU4M3YzNGVXbWVPQTJ5YzFTb1JabEhXNFN4?=
 =?utf-8?Q?G+03p8kojsoqeXwpoNtzuFMPrei37BL+aUBnXbpteV2U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87a7b358-7976-478c-ea8e-08db3b50d053
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 12:24:08.3843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: damCiX+BEHrJgH1SDR1v9UrtPgkV3U4R1pBye3XQbhUDE6ZVVMyZfrWaFwkt+N+h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8819
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.04.23 um 14:10 schrieb Tvrtko Ursulin:
>
> On 12/04/2023 10:34, Christian König wrote:
>> Am 12.04.23 um 00:56 schrieb Rob Clark:
>>> From: Rob Clark <robdclark@chromium.org>
>>>
>>> Similar motivation to other similar recent attempt[1].  But with an
>>> attempt to have some shared code for this.  As well as documentation.
>>>
>>> It is probably a bit UMA-centric, I guess devices with VRAM might want
>>> some placement stats as well.  But this seems like a reasonable start.
>>>
>>> Basic gputop support: https://patchwork.freedesktop.org/series/116236/
>>> And already nvtop support: https://github.com/Syllo/nvtop/pull/204
>>>
>>> [1] https://patchwork.freedesktop.org/series/112397/
>>
>> I think the extra client id looks a bit superfluous since the ino of 
>> the file should already be unique and IIRC we have been already using 
>> that one.
>
> Do you mean file_inode(struct drm_file->filp)->i_ino ? That one would 
> be the same number for all clients which open the same device node so 
> wouldn't work.

Ah, right. DMA-buf used a separate ino per buffer, but we don't do that 
for the drm_file.

>
> I also don't think the atomic_add_return for client id works either, 
> since it can alias on overflow.

Yeah, we might want to use a 64bit number here if any.

Christian.

>
> In i915 I use an xarray and __xa_alloc_cyclic.
>
> Regards,
>
> Tvrtko