Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Colin Foster <colin.foster@in-advantage.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 5/8] net: dsa: felix: remove confusing/incorrect comment from felix_setup()
Date:   Wed, 12 Apr 2023 15:47:34 +0300
Message-Id: <20230412124737.2243527-6-vladimir.oltean@nxp.com>
In-Reply-To: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LQAXkWz4eReDrWcNYG3CMaYlLZGFYUqxO+Og4GX7MAFkF2A+SCApXvixYX+z?=
 =?us-ascii?Q?Ok3CG+iGvwjwD79eCEuYiWYJu+UgLCnplrXpxnYSGBhnzbG+upIhDc2FEDvo?=
 =?us-ascii?Q?wibhg6Owb1qMgT0A3MUeX2kruEzXU+VeHb0O8un81VxfhnNpLM0dwfh5mwSA?=
 =?us-ascii?Q?hL+Q5J0zbujKKkslTZJG6o35t/74EZ9WiIgzGDFYyzJhQXTp4wsQuw/1ULKs?=
 =?us-ascii?Q?5/baNZRlGkodTqiY6OBFtNgaKY0X7FWpygUbm/zrojs482/hq7sxRsrhkKkX?=
 =?us-ascii?Q?lOzNPsRFZbk+bJkO8dZ86vTFNDTkoW4y1xtzj/3n21Tll7BMLelXbH+WQGkz?=
 =?us-ascii?Q?ZJNlT4CXXU5KSeEHcq2iJqi9tYKPlq8bmDLMUZFsxhfVsD/xg4SpR1KUlWfG?=
 =?us-ascii?Q?DfzSmYo+d3dz10Oivqc4O1bIMGjRibUG/7MEof4oHiO9s75sRm2N9JCvDWK8?=
 =?us-ascii?Q?FwQBSPIdKBrpMFiSkxCpNl5W6n8XdyaY7kOVob0OKZAYcMsN2e/u2rw/JQ96?=
 =?us-ascii?Q?gDgIWbsCef6nQFVz4Q1LtOBrwME2VnGL5bLv04d3gCifvP5EaNlozUfgzspa?=
 =?us-ascii?Q?pdFYol8ERWfaet1xLSbHCRQMV8fWXus6EyBM6MjNbdqAEVtHVMGO8d++JaLG?=
 =?us-ascii?Q?B+v9TijPDS4ocqc6E1kif4yrjv3hmUTsB3Ro38S6iNVK2I+EJrkhaQ0XcUHE?=
 =?us-ascii?Q?S4dzoI2wmdOFfoY9XFlogpa29bxMKM56YU0HdFjGJZeU53+apRonxD/f4a7L?=
 =?us-ascii?Q?WA7vpG1zdhBBY+gnwnLdNOtsDN3cAL0eGAHnMuLovbrdW11nmPmdyJMbMbGb?=
 =?us-ascii?Q?ifKuArbK84n8nUQBmF7sXSuu59fi+y+SuAg9aBEOcbUyliq5YgTSQhwXtyJC?=
 =?us-ascii?Q?uXrirbtXUM1kRbLiZ6QhTTOu+1dHzuSU38ea8JX3nwPMjo91zKyqtmSww2vh?=
 =?us-ascii?Q?o+UAGyJILn6sy8qnPvtx56bvubCfHw0fRwfwsaiNwVcDm7Trd1oZhiuYd1qW?=
 =?us-ascii?Q?N7RMljxa85q1PKTBWxe3kWPqhWYxtUXZtprPegOmrlsDC3WymQKheWrEWhtf?=
 =?us-ascii?Q?ak+ivKhsuv4x5BIQEI7aqG/rcHqrHqm7+3L6UV/q94oVf4PSYTCe9HtcHjz0?=
 =?us-ascii?Q?fDwFQJK/YCVO1FZGp5OkTa6HC7avjzbeiSLpX8Ax6rlGB0wBs085b+9U/JVK?=
 =?us-ascii?Q?zDgS5KYXPrDmlqvt/h23P1lx1tc3nN0sAEiKg7vMg85YQjsGCTnd5x1C6RWG?=
 =?us-ascii?Q?E43CRLyliMrP7tn9S3hG/K7EnTEu6vspQ/e1R2c13wwkwrEpL28vdqzx82uE?=
 =?us-ascii?Q?vBn7nXk5hM0p4wVrnsyx7nLLW6R5Lcv/AIDD+3BkLQv1X2tcjqjcjVD6o6+K?=
 =?us-ascii?Q?JEYwwsAQlsamKL3noVW4EJJ+WHmadBaGrzeLmztd0bxoWevFepLIB1K3qmBw?=
 =?us-ascii?Q?Dbk7U4XQf329rs/HDOnN+V+XzRnfMSZRUoeaNndG7HRWS+l0WrzzeVKgfaVv?=
 =?us-ascii?Q?ZOE65pbCK0Zg6LuaTI7T0TMcxfmUsqioST89rs2kXrFCuxDmjcYA7eMKSHyq?=
 =?us-ascii?Q?C6g90c9AS2nU/NmAa1DXJd0FW7CLmVFm3ujNY3549kYwVWMPrZdbtLpdZuI9?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1da837a-b138-44b1-1dfa-08db3b542407
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 12:47:57.2774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jWECevEO4sCscfSMPAI9V+mcXhXs0jttNgHJVA/rVG53svh1lMSAI5eYxWo+Z+Olm1U0tS57NeY7ypojpxFkNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6888
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        T_SPF_PERMERROR,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

That comment was written prior to knowing that what I was actually
seeing was a manifestation of the bug fixed in commit b4024c9e5c57
("felix: Fix initialization of ioremap resources").

There isn't any particular reason now why the hardware initialization is
done in felix_setup(), so just delete that comment to avoid spreading
misinformation.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/ocelot/felix.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 6dcebcfd71e7..80861ac090ae 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds,
 	}
 }
 
-/* Hardware initialization done here so that we can allocate structures with
- * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing
- * us to allocate structures twice (leak memory) and map PCI memory twice
- * (which will not work).
- */
 static int felix_setup(struct dsa_switch *ds)
 {
 	struct ocelot *ocelot = ds->priv;
-- 
2.34.1