Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Colin Foster <colin.foster@in-advantage.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 3/8] net: mscc: ocelot: debugging print for statistics regions
Date:   Wed, 12 Apr 2023 15:47:32 +0300
Message-Id: <20230412124737.2243527-4-vladimir.oltean@nxp.com>
In-Reply-To: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7kuLUF6uAuCOef+rAVgdEvGBtVqwpN7geWGr9u3Y11qtGjOTdjUDT6nYxuG6?=
 =?us-ascii?Q?c9Y4EeiO83RT4HjiHfOA/SECPZWiX8TLoRNRAHb3CcTAYDterWwxxmhyDgxE?=
 =?us-ascii?Q?yknaglO2CwQJj3k/ti4GKRvhzOy2w4kJdbtulnVOVrR9nx9codm7MUe/viuy?=
 =?us-ascii?Q?ODrgNYwPBjfWKJ6E8kqBmPN7yT+fdCxDav6AdIUzaC/MJ1ADmWGVanXuo3ZC?=
 =?us-ascii?Q?MXMXAylmoSLW1j1aYYa0ViTQRTHbrIvIqx0CRrtZJZ9Bp+mQ8tsRjhyZsbo9?=
 =?us-ascii?Q?bZ7QguTyHU49LltaGgtwh0UlJpEA9JXj85/Gpmi7LF6px7huLCC+rop94D3e?=
 =?us-ascii?Q?Rb5GIS+8lazmeqAzOCArN9cY1pmWITh7zniwGye/EGm3oKCGZLBMXnkiSOy5?=
 =?us-ascii?Q?3aIotTxnvN4SGZW+Xp5k6FrtJz+4e0xURffvFIh94ViUMpWBTOCftIUsquc8?=
 =?us-ascii?Q?OkYrFEAZmzyKC3/zDRh4z6Jn+J7aHPNv3GT8nnBOM2T9kplLezvkctlPzAGz?=
 =?us-ascii?Q?1Dt0YbnFeJ2R26eIvBPf/VWVbBr7OvaYZFFSurcCdlL2q4YSwGqAW2fWe5xt?=
 =?us-ascii?Q?ZDB72qaGaVU1JHjapR46EwKFXR4b36hSMZMqZQehUF5vHfmzeTag+r+m+J6V?=
 =?us-ascii?Q?+FfVQnP8w/u89l9MYIt5trp3sjdWe9iMqlaVXIAiNKj2LcyYIdgTAEY2yIV+?=
 =?us-ascii?Q?wsHRfPAaBtXStnJ3ztLVKPmZOIIESzxcGWNfRWY8Q7JctX9XXmCTyOIHYT6v?=
 =?us-ascii?Q?s9FdwHxYRjELYlChDR4ISDPjfPv1p3SkxfeOgZ+j2zVy0NOd0lnaniEpGCHI?=
 =?us-ascii?Q?jrlrX7XXo7olwsbgEvYrhner6A5JcxM13GHVIFisD2JO17pdgLOSdSVQlx+W?=
 =?us-ascii?Q?l8Nsb0d29hq+exdMElHbHTU9MRuKJI4jcx7zo3czydCCB1C6LGRiTYytZn1K?=
 =?us-ascii?Q?YTBBU9rgbTEf3LSDY0hEQIcmkD+oDecUXmKygm07zS33nw6cPDI2mAm+0OAj?=
 =?us-ascii?Q?z215nXsJa4zoF9b/+dkf/GrMJu/VaoTv+qNEOSBB74fwIc8LTt6IV+U1YYIP?=
 =?us-ascii?Q?Vt5C1ooYRX3uU12IIiwjoRbmaU5PP3WfP1AvI9GuYBeFQm+7aKpYIZfH9tcW?=
 =?us-ascii?Q?K+JGh7NIx0jqEiRgNFLBGHCso0xt2RWjY14wXW41pJtoolfSR3304hMgNUYo?=
 =?us-ascii?Q?W+UiRSGXtwISKJWzLttIkTKoUjq0u5a5oCZQq5bYbq3i0adaB5o8c+EInmOB?=
 =?us-ascii?Q?5gMZorik+ar9+fVfEwW6xeryG2vKWah8B/f2ufUIxb0RQQ4UTc/tYPu1FZO1?=
 =?us-ascii?Q?l/CjqivkJLZyJiFJuMBbpSfQVbp3nNmhEnNxguf5k11/f+WjagkXgCIyqViP?=
 =?us-ascii?Q?pWto+zsW7TkHFsbN1yNwcKf8NvCAvgyzOv3nx4a+Vo2di7RPzZ7PZUZl096P?=
 =?us-ascii?Q?/UkMLfBiRABzthnDYa7hC8LxmbrX6cY6FOGgEl68sHYPewVdt/e79paAqPWn?=
 =?us-ascii?Q?9xTPx3Eo0+a53uZl7QhVcqLOflsPzZBViRH2g4tPIjJn3Xbu950HgZiQRNn+?=
 =?us-ascii?Q?kgswNGrfJV2LQUH0dmpTNMHxrOS+7UfYjfyykrJ9bb6c076j19R1DGLU4xfx?=
 =?us-ascii?Q?Mw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19106e46-226d-4f6a-588a-08db3b5422b9
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 12:47:55.0822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sh9hWutSYRWV9goJleANIHn0glIzBI4VYaUayBcuO0DMDhHk/CbNJruUVxpfbQsCpzXmRWbGN0frcXbcZmpJOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6888
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To make it easier to debug future issues with statistics counters not
getting aggregated properly into regions, like what happened in commit
6acc72a43eac ("net: mscc: ocelot: fix stats region batching"), add some
dev_dbg() prints which show the regions that were dynamically
determined.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot_stats.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c
index d0e6cd8dbe5c..b50d9d9f8023 100644
--- a/drivers/net/ethernet/mscc/ocelot_stats.c
+++ b/drivers/net/ethernet/mscc/ocelot_stats.c
@@ -925,6 +925,15 @@ static int ocelot_prepare_stats_regions(struct ocelot *ocelot)
 	}
 
 	list_for_each_entry(region, &ocelot->stats_regions, node) {
+		enum ocelot_target target;
+		u32 addr;
+
+		ocelot_reg_to_target_addr(ocelot, region->base, &target,
+					  &addr);
+
+		dev_dbg(ocelot->dev,
+			"region of %d contiguous counters starting with SYS:STAT:CNT[0x%03x]\n",
+			region->count, addr / 4);
 		region->buf = devm_kcalloc(ocelot->dev, region->count,
 					   sizeof(*region->buf), GFP_KERNEL);
 		if (!region->buf)
-- 
2.34.1