Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 15:34:33 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Simon Horman <simon.horman@corigine.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: smsc: Implement .aneg_done callback for LAN8720Ai
Message-ID: <7330ff6d-665f-4c79-975d-6e023c781237@lunn.ch>
References: <20230406131127.383006-1-lukma@denx.de>
 <ZC7Nu5Qzs8DyOfQY@corigine.com>
 <aa6415be-e99b-46df-bb3b-d2c732a33f31@lunn.ch>
 <20230412132540.5a45564d@wsk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412132540.5a45564d@wsk>
Precedence: bulk

> > This actually seems like a fix. So it should probably be based on net,
> > and have a Fixes: tag.
> 
> I've rebased it on the newest vanila kernel.

Please see the netdev FAQ. It talks about the two git trees used for
networking.

> It turned out that this IC has a dedicated bit (in vendor specific
> register) to show explicitly if auto neg is done.
> 
> > 
> > Lukasz, how does this bit differ to the one in BMSR? 
> 
> In the BMSR - bit 5 (Auto Negotiate Complete) - shows the same kind of
> information.
> 
> The only difference is that this bit is described as "Auto
> Negotiate Complete" and the bit in this patch indicates "Auto
> Negotiation Done".
> 
> > Is the BMSR bit
> > broken? 
> 
> This bit works as expected.

I would avoid the vendor bit, if it has no benefit. A lot of
developers understand the BMSR bit, where as very few know this vendor
bit. BMSR can probably be handled with generic code, where as the
vendor bit requires vendor specific code etc.

    Andrew