Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Wed, 12 Apr 2023 16:09:54 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Roman Beranek <romanberanek@icloud.com>
Cc:     Frank Oltmanns <frank@oltmanns.dev>, Chen-Yu Tsai <wens@csie.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from
 TCON0_DCLK_REG
Message-ID: <qrjzn5dy7qasjubovofyzsazakiqpsjyyt2av6kfbqq7mqcdqe@bvs2egtopbqs>
References: <20230320161636.24411-1-romanberanek@icloud.com>
 <87wn356ni4.fsf@oltmanns.dev>
 <20230327202045.ceeqqwjug4ktxtsf@penduick>
 <CRHKFX934UA0.1MCKCD8SJSPIE@iMac.local>
 <20230329195802.veybo3367zifw77n@penduick>
 <CROTQHUM88W0.2URPO95U5ZMS5@void.crly.cz>
 <pu3vdz4gnkwgn4thg6tndbnvfroevpnq75bqbfv7yyrh4gkv63@xxl3dsjf2ih3>
 <CRULBWW4VCWG.3KS7HX7P1G4P6@void.crly.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gw23oqhzikhjtwgb"
Content-Disposition: inline
In-Reply-To: <CRULBWW4VCWG.3KS7HX7P1G4P6@void.crly.cz>
Precedence: bulk


--gw23oqhzikhjtwgb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 12, 2023 at 09:14:59AM +0200, Roman Beranek wrote:
> On Wed Apr 5, 2023 at 5:03 PM CEST, Maxime Ripard wrote:
> > On Wed, Apr 05, 2023 at 02:34:11PM +0200, Roman Beranek wrote:
> > > It turns out however that the new dclk rates can't be set exactly as
> > > requested without touching pll-video0*, tcon0 now therefore gets
> > > reparented from pll-mipi to pll-video0-2x which, as it further turns
> > > out, breaks DSI. While simply forbidding the video0-2x mux option see=
ms
> > > to me as the right way to go because there's not much use for it with
> > > non-DSI interfaces either besides the opportunity to power pll-mipi
> > > down, I'd like to run by you first.
> >
> > Sounds reasonable
>=20
> Okay, I'm unsure of how to denote that in the code however. Should I
> just comment the parent out of the table and put an explanation in
> a comment nearby? Or just erase it? I couldn't find an applicable
> precedent.

I think that forcing the parent at boot, and adding the
CLK_SET_RATE_NOREPARENT flag should be enough.

> > > * As pll-mipi doesn't have CLK_SET_RATE_PARENT flag set, pll-video0
> > >   retains its boot-time rate of 294 MHz set by sunxi-dw-hdmi driver
> > >   in u-boot. Why 294 MHz (as opposed to the default rate of 297 MHz)?
> > >   The driver actually asks for 297 MHz, clock_set_pll3 rounds it to
> > >   294 MHz though because it limits itself to 6 MHz steps.
> >
> > We could also address that though
>=20
> Should I include it in v2 of the series, or leave it for later?

I guess you can include it into this one too

Maxime

--gw23oqhzikhjtwgb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZDa7sgAKCRDj7w1vZxhR
xcbdAQDlABOUSRin2TeBWh2nNqjI2tuMlU0bJZQjxFS9a+mQiQEAv5twOP7R+ugi
y49VRW9d7AF34brzpVy7yy+Tzffp1A8=
=0sQH
-----END PGP SIGNATURE-----

--gw23oqhzikhjtwgb--