Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 16:26:16 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Aaron Lu <aaron.lu@intel.com>
Cc:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel@vger.kernel.org, Olivier Dion <odion@efficios.com>,
        michael.christie@oracle.com
Subject: Re: [RFC PATCH v4] sched: Fix performance regression introduced by
 mm_cid
Message-ID: <20230412142616.GI628377@hirez.programming.kicks-ass.net>
References: <20230410150150.2179062-1-mathieu.desnoyers@efficios.com>
 <20230411045225.GA3509@ziqianlu-desk2>
 <20230411131221.GA7356@ziqianlu-desk2>
 <20230412091043.GC4253@hirez.programming.kicks-ass.net>
 <20230412114240.GA155547@ziqianlu-desk2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412114240.GA155547@ziqianlu-desk2>
Precedence: bulk

On Wed, Apr 12, 2023 at 07:42:40PM +0800, Aaron Lu wrote:

> I *guess* you might be able to see some contention with hackbench on
> that HSW-EX system with v4.

Indeed! Notably it seems to be the wakeup from idle that trips it
hardest:

11.31%     0.03%  swapper          [kernel.vmlinux]            [k] schedule_idle
        |
        --11.28%--schedule_idle
                  |
                  --11.27%--__schedule
                            |
                            |--8.61%--mm_cid_get
                            |          |
                            |           --5.78%--_raw_spin_lock
                            |                     |
                            |                      --5.56%--native_queued_spin_lock_slowpath
                            |
                            |--0.81%--finish_task_switch.isra.0
                            |          |
                            |           --0.69%--asm_sysvec_call_function_single
                            |                     |
                            |                      --0.58%--sysvec_call_function_single
                            |
                            --0.57%--switch_mm_irqs_off