Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 17:27:33 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Ido Schimmel <idosch@nvidia.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <20230412142733.6jhxt7kjf3nwqzsy@skbuf>
References: <20230410204951.1359485-1-vladimir.oltean@nxp.com>
 <ZDa856x2rhzNrrXa@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZDa856x2rhzNrrXa@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XV8Q48Xu3Jsfkq08jp2BsJPy8tZywIi6gG7P4hTFCKXFwrKnWmftQe7FoUBL?=
 =?us-ascii?Q?aQTZvwPG7JXVx7yfTralIYgC+wFMT61xNwdFK/PCc5lix43A0skfkuCFvfqR?=
 =?us-ascii?Q?HdC3EANdiqlBybj2LB1CEfOG+gADh41J5yHyma/j5F/GScVQROu2HFt2oA8h?=
 =?us-ascii?Q?KydzV//AisufPgPw2OPP/QgN2VbysYJpfyukNpabcEN3tORCSPiEzsMzLpT4?=
 =?us-ascii?Q?sAELfzQ0qklYEiHU7HbfFfrvSCyJ4EaJNQ9ms7m8wDdpwcz9H19Jk/2JigoC?=
 =?us-ascii?Q?peb2ZaGIVAParOakISHNZ4lmz8/YqTKt7jte8qY32W6HdKOb/xM2Hh+XCVOc?=
 =?us-ascii?Q?vo0m+abqLhRZXAMoLu5y3gd0rrzMnHUAm+p2e80F5n8zbpMQGu0P7tz4O87Y?=
 =?us-ascii?Q?fWy/QHP3lRK6EM9KSfAgl66ZAQ021IuNIODM6+UVJV5Unki4rUFCi168iB/S?=
 =?us-ascii?Q?mvtPJ3IYRsIA02WctxF2aclAhhGz2G9sU0tGTV/8/omz3ESP1glkQmNrzHF9?=
 =?us-ascii?Q?J03u0UrmDi+ZnIK2dcAPsNe5B7B1rOJy1cux1JZGl52oCid59gzoBdF02E1o?=
 =?us-ascii?Q?wSQoyHoFMqQclq2QM+cdWeAgpc4Aa18fLr6pGn9h8saKLq0PfP7UufASMqWe?=
 =?us-ascii?Q?u96TP4vQ6NCei3LuzyOZf/zbLjbYDvydhiYG3gEV9L9Sfo2iVy+opm7Ysd/V?=
 =?us-ascii?Q?rU/70WeGWsvWBGvLqfMdpBjIGxPATvQaC3sND1b9x3liZyO4moXQt0d8rhHH?=
 =?us-ascii?Q?nFKnNRwLFF7vItaGMjQrIMJqdACRYqRV20p6SYey0wBTucv3NgN0wQS8uQ0d?=
 =?us-ascii?Q?JK8jPXFxPT+aoiS0VGLj7Pp65henbhlYG8RIgN8oMG2/yVokq6H9z+jbNPng?=
 =?us-ascii?Q?YyLmHsFBv6AQY2RzTY+FwJTlyhNkzCzRk3eF3ymWsUMQ8z8/igaiMdHfpBSG?=
 =?us-ascii?Q?oXtQSOm4C2AzWKqyazjY73mw/7JfVn9U/RID3L4sjDHJfTNrQ91iaRnz1ByZ?=
 =?us-ascii?Q?2BhD4NIPdDQ4yEgzGqzcZKAorlWtStP7gUG8Hf/dY92xSkibMLbQCMxvzL/R?=
 =?us-ascii?Q?vUT14gsQORTFmLcNuYPo8m44bG2ic6QJ2qAKBTxlJc9sFqx4QoxNGVWoUsgI?=
 =?us-ascii?Q?xsVpIqOSIZKhvVd1N6cUG1OMuYMRreMaHzM5R4wms9vbEyqCWQNOZ1Mc6yg2?=
 =?us-ascii?Q?NaPPYmf6Blh6e3Uc8tkQd/XuqTeK0vT6d/J2u3X9zxzDGMEnq0/LLIlap6++?=
 =?us-ascii?Q?Awaixd4d7nNrTCQAMH7wu9cOI61POnUpXMr6hykeHjf1D256OWDMQCYZ8naJ?=
 =?us-ascii?Q?G7xF6wG/5wxQvr8BECVEuaZwNhmIHqAbNtuWQdW2SE3CZmgoMEat9pxbwNkn?=
 =?us-ascii?Q?6VZGOynKm+exDqRV2Tt4pxS5XGOxuFGt1lk4g1Whztu1zpQKfVWDsaa9lVLF?=
 =?us-ascii?Q?c13JdG/fVO9TUcC/2/DYyuF2Jpv3FITDwTQTB/CWeGRsuuOpAdykNfJz/Vfh?=
 =?us-ascii?Q?gpkMhHtqP0dKkXrk32IVSKfhMo5SwrekDX4Lbylck24KQyT3q5fVBBhSDCCe?=
 =?us-ascii?Q?5b/BFhT4czLKd//anSli6cmjdSSZRvQDmH4jq723ghZsu/Yv7tLlvSC+pbWg?=
 =?us-ascii?Q?PQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a236b2b-df91-4247-9ca8-08db3b62102e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 14:27:36.9015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wyRd5Gk6bC067NsXwmWXDuZS8KmNJ7WbSuYBBkj3QrK1FipCh5n078kVzEEEhvNsI3JHiyiHiH1VA25Q1CIhKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9240
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 12, 2023 at 05:15:03PM +0300, Ido Schimmel wrote:
> > Looking at tools/testing/selftests/net/forwarding/, there is no valid
> > use of the "bridge fdb add ... master dynamic" command there, so I am
> > fairly confident that no one used to rely on this behavior.
> 
> Yes, but there are tests that use "extern_learn". If you post a v2 that
> takes "BR_FDB_ADDED_BY_EXT_LEARN" into account, then I can ask Petr to
> run it through our regression and report back (not sure we will make it
> to this week's PR though).
> 
> Thanks

How are extern_learn FDB entries processed by spectrum's
SWITCHDEV_FDB_ADD_TO_DEVICE handler?