Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1046141rwl; Wed, 12 Apr 2023 07:36:28 -0700 (PDT) X-Google-Smtp-Source: AKy350aqi63hEFioHB8o1qwReS0wG/iAhXBCMCSFL3qh0BrcSWptUzhrnp7rrtUXP/NeSbvmTKub X-Received: by 2002:a17:906:350a:b0:931:20fd:3d09 with SMTP id r10-20020a170906350a00b0093120fd3d09mr3101122eja.17.1681310188565; Wed, 12 Apr 2023 07:36:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681310188; cv=none; d=google.com; s=arc-20160816; b=RrETl9EU0A0JYwmZKx+BjtO4uoMDhj2jsN2NZvvSi9xRH/lfAcuk088U2dho7osBgm nytQhYnfy3mQg/4s0apMXJF8lef/U1Eh2jjpKc82UCh+9/wtJltSpmu6xAL7K6BHr9PD syNbjNgy48Ipo/iRVLnbpqBgaxEgzPvtEXNKrfOvoYelaxUl6dZGJLYDge8QkJLdYn/0 MWxXfzS/Gtse1oY4JTi/75QiFo2NRsYb93ORiTRbZkUq1fGm+PQYiAM6HcxYxwJ+vgq7 xK0s4dV0GwDdhD2swvDGHdKjdkRGx/Q9tdVipuhPwxuxmGfAO6YLvGfpSxbOezPz5RZA 90Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=+o5ReY+oZ/UrMSbO9TjM2NPAwZL+TDT/jBB85AGbcgQ=; b=THrOIlatF1/1exXv8HQziP8Y/lId3ecHsSk3noxBSTH6Wt+KCEFah+KqAdOU8HFjUz CvN1y7/s1St66HreLeoNY3oI2RYmDjMiHbyzwx2vWKDMUk+Vnyk3x26i5hIQaq9VVv/0 bu50aJfBtL8C7/Yh4ySbsSoKu+h3pNSA1b44tIhV/NOtsIAIzgfCKRqs4OPyMxICgdCI cFqTDsqr11sNaOM3qR+5WRlOMgF506EXD+w2aoQVwxSZn/WM+DKS9crlJ9u0pqjDIg81 SNNVDKYW7Gg3NuPxnGoK2jxSk+b+njZVotezBeRq47zBuP05HS/BcQUyvztUihucuGuo OZNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vt10-20020a170907a60a00b0094e559b4266si340194ejc.867.2023.04.12.07.36.03; Wed, 12 Apr 2023 07:36:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbjDLOez (ORCPT + 99 others); Wed, 12 Apr 2023 10:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231688AbjDLOet (ORCPT ); Wed, 12 Apr 2023 10:34:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77BFE9763; Wed, 12 Apr 2023 07:34:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB7AB635A9; Wed, 12 Apr 2023 14:34:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1C72C433EF; Wed, 12 Apr 2023 14:34:30 +0000 (UTC) Message-ID: <4ae9a945-6cde-8083-432a-94b6b250d88c@xs4all.nl> Date: Wed, 12 Apr 2023 16:34:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 11/14] media: mediatek: vcodec: Remove the setting for dma_mask Content-Language: en-US To: Yong Wu , Joerg Roedel , Matthias Brugger , Mauro Carvalho Chehab , Rob Herring Cc: Will Deacon , Robin Murphy , Krzysztof Kozlowski , nfraprado@collabora.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, AngeloGioacchino Del Regno , mingyuan.ma@mediatek.com, yf.wang@mediatek.com, jianjiao.zeng@mediatek.com, Yunfei Dong , kyrie wu , chengci.xu@mediatek.com, youlin.pei@mediatek.com, anan.sun@mediatek.com, Tiffany Lin , Andrew-CT Chen , irui wang References: <20230411093144.2690-1-yong.wu@mediatek.com> <20230411093144.2690-12-yong.wu@mediatek.com> From: Hans Verkuil In-Reply-To: <20230411093144.2690-12-yong.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2023 11:31, Yong Wu wrote: > In order to simplify the masters to set their respective dma masks, MTK > IOMMU helps to centralize the processing. Because all the dma ranges is > set in IOMMU, IOMMU knows well the dma mask requirements of masters. After > this patch, the masters(codec here) code does not need care > dma-ranges/dma_mask related information. > > Cc: Tiffany Lin > Cc: Andrew-CT Chen > Cc: Yunfei Dong > Cc: Mauro Carvalho Chehab > Cc: irui wang > Signed-off-by: Yong Wu Acked-by: Hans Verkuil Regards, Hans > --- > .../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 8 -------- > .../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 3 --- > 2 files changed, 11 deletions(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c > index 174a6eec2f54..11583405cf61 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c > @@ -321,14 +321,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > } > } > > - if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) { > - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > - if (ret) { > - mtk_v4l2_err("Failed to set mask"); > - goto err_core_workq; > - } > - } > - > for (i = 0; i < MTK_VDEC_HW_MAX; i++) > mutex_init(&dev->dec_mutex[i]); > mutex_init(&dev->dev_mutex); > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > index 9095186d5495..50e5571608cd 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > @@ -344,9 +344,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > goto err_event_workq; > } > > - if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > - > ret = video_register_device(vfd_enc, VFL_TYPE_VIDEO, -1); > if (ret) { > mtk_v4l2_err("Failed to register video device");