Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1110165rwl; Wed, 12 Apr 2023 08:22:40 -0700 (PDT) X-Google-Smtp-Source: AKy350ZKOl6iq4mUhZhjXxyEgmox0MvmjXa3rWQvZkTyhr8RSYGnqDYJmyF5e5MasA0uFsJFptrV X-Received: by 2002:aa7:96fb:0:b0:628:87f:6b5d with SMTP id i27-20020aa796fb000000b00628087f6b5dmr7250078pfq.11.1681312960093; Wed, 12 Apr 2023 08:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681312960; cv=none; d=google.com; s=arc-20160816; b=WCA38JFZM0UkCmMWbaEBrttPq6/Cd4CjGoRkjRuSEJeKCmJkWSWS38ZlISjDmwSJtA l4FBTk5YuOUN87m2SRXfAfUHXWkl98z51GkCs6pf/6v4N/oK1vPvm0GgWCt/YTRZCa+o oekKOcX9aXRZ58NkkDvLe3BxNPNyyYu/xV0z6+yvi6nEw/YAvvzSz3dLq2T2WWonATJF abhwP8FiC1d1sdwSi0vS9iTtq/qi9igkesIj2pW2Hlp7uht+2hhgtc70M0ZK/okfnyte xksMX6RmlwRC+GmbUIIEcrXynS8sCJ2VKyln55fE70dBMkbC0g3Q8l/Ol+eyC2YlBNVU CoXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2WC19rJXxAihzgCfOS6b733MqpAVNj+VT/XngzSDYUg=; b=rRBVJ+4mvCVQfYcVx1r7aIDaZHTw16R7RkdDR+gGwtiqfHilk/VYWOoC9Uds7y7z/V FgpwoqnX7XHr+y1xsN0ZJOi2gIBv0V2InUUUW1TmmZ74eXGyvzofnIqoSl2bvr55gcAq GaZJHN8zUniQBq9L2++Fp01+c9kVIVAPs0V0zFkW3LvTg3HdrQlSY0unJUJKqW+8VmCg HefeosbonH6Pqn++9H3elU653ILrcgYLLrUR3O1TW6od3FjUAoHcQFEk+AB0/csV8QHx RWaXEx2uT6L62H/z0+fHqExqCLKFsZUzPPn5pqeO8u/wht4qjLsh9Gqz0c08y//UCwJT Chfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g10-20020aa79f0a000000b0063811bd03e7si8247975pfr.185.2023.04.12.08.22.27; Wed, 12 Apr 2023 08:22:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231487AbjDLPVc (ORCPT + 99 others); Wed, 12 Apr 2023 11:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbjDLPVV (ORCPT ); Wed, 12 Apr 2023 11:21:21 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75A0619A for ; Wed, 12 Apr 2023 08:20:53 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 241DB68AA6; Wed, 12 Apr 2023 17:20:39 +0200 (CEST) Date: Wed, 12 Apr 2023 17:20:38 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v9 3/3] mm/zswap: delay the initialization of zswap Message-ID: <20230412152038.GA26518@lst.de> References: <20230411093632.822290-1-liushixin2@huawei.com> <20230411093632.822290-4-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411093632.822290-4-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2023 at 05:36:32PM +0800, Liu Shixin wrote: > Since some users may not use zswap, the zswap_pool is wasted. Save memory > by delaying the initialization of zswap until enabled. > > Signed-off-by: Liu Shixin Looks good: Reviewed-by: Christoph Hellwig